Perf fix: create a unified should_skip_attack_scan #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitterpanda63
changed the title
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| return False | ||
|
|
||
| should_skip = False | ||
| # We check for a boolean protectionForcedOff on the matching endpoints, allows users to disable scans on certain routes. |
There was a problem hiding this comment.
Comment restates the mechanics of the upcoming conditional instead of explaining the higher-level reason or intent.
Feedback
Post a comment with the following structure to provide feedback on this finding:
@AikidoSec feedback: [FEEDBACK]
Aikido will process this feedback into learnings to give better review comments in the future.
More info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes slowdown by not fetching & checking thread cache for bypassed ips & forced protection off every time