Skip to content

Adding . in front of platform description #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Adding . in front of platform description #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
178ac7a
Adding `.` in front of platform description
goergisn Nov 15, 2024
c10c77c
updating api change workflow to use main branch
goergisn Nov 15, 2024
1827273
fixing release branch handling
goergisn Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/detect-api-changes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: 👾 Define Diff Versions
run: |
NEW="${{ env.source }}~${{ env.githubRepo }}"
if [[ '${{ github.head_ref || env.noTargetBranch }}' == 'release/*' ]]
if [[ '${{ github.head_ref || env.noTargetBranch }}' == release/* ]]
then
LATEST_TAG=$(git describe --tags --abbrev=0)
OLD="$LATEST_TAG~${{ env.githubRepo }}"
Expand All @@ -56,7 +56,7 @@ jobs:
noTargetBranch: 'no target branch'

- name: 🔍 Detect Changes
uses: Adyen/adyen-swift-public-api-diff@github-action
uses: Adyen/adyen-swift-public-api-diff@main
id: public_api_diff
with:
platform: "macOS"
Expand Down
2 changes: 1 addition & 1 deletion Sources/Shared/Package/SwiftPackageFileHelperModule/SwiftPackageDescription.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ extension SwiftPackageDescription {
extension SwiftPackageDescription.Platform: CustomStringConvertible {

package var description: String {
"\(name)(\(version))"
".\(name)(\(version))"
}
}

Expand Down
10 changes: 5 additions & 5 deletions Tests/UnitTests/SwiftPackageFileAnalyzerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,14 @@ class SwiftPackageFileAnalyzerTests: XCTestCase {
),
.init(
changeType: .change(
oldDescription: "platforms: [iOS(12.0), macOS(10.0)]",
newDescription: "platforms: [iOS(15.0), visionOS(1.0)]"
oldDescription: "platforms: [.iOS(12.0), .macOS(10.0)]",
newDescription: "platforms: [.iOS(15.0), .visionOS(1.0)]"
),
parentPath: "Package.swift",
listOfChanges: [
"Added visionOS(1.0)",
"Changed from iOS(12.0) to iOS(15.0)",
"Removed macOS(10.0)"
"Added .visionOS(1.0)",
"Changed from .iOS(12.0) to .iOS(15.0)",
"Removed .macOS(10.0)"
]
),
.init(
Expand Down
Loading