Skip to content

Improving SwiftPackage analyzing #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 19, 2024
Merged

Improving SwiftPackage analyzing #15

merged 10 commits into from
Sep 19, 2024

Conversation

goergisn
Copy link
Contributor

@goergisn goergisn commented Sep 13, 2024 •
edited
Loading

Summary

Swift PAD now surfaces warnings and changes to the dependencies, targets & products of a Swift Package (see attached screenshots)

Changes

  • Added additional properties to SwiftPackageDescription
  • Added CustomStringConvertible & Equatable to most SwiftPackageDescription structs
  • Added packageDescription(at:) function to the PackageFileHelper that returns a SwiftPackageDescription for further inspection
  • Updated diagram in README.md

Example

Warning

Invalid Resource 'PrivacyInfo.xcprivacy': File not found.

Package.swift / dependencies

❇️ Added

.package(url: "https://github.com/Adyen/adyen-authentication-ios", exact: "3.0.0")

🔀 Changed

// From
.package(url: "https://github.com/Adyen/adyen-3ds2-ios", exact: "2.3.0")

// To
.package(url: "https://github.com/Adyen/adyen-3ds2-ios", exact: "2.4.2")

Package.swift / targets

🔀 Changed

// From
.target(name: "AdyenEncryption", path: "AdyenEncryption")

// To
.target(name: "AdyenEncryption", dependencies: [.target(name: "Adyen")], path: "AdyenEncryption")

/**
Changes:
- Added dependency .target(name: "Adyen")
*/

@goergisn
Improving SwiftPackage analyzing
f251ce1
@goergisn
Fixing some leftovers
0731f48
@goergisn
Removing commented out code
9ecb578
@goergisn
Surfacing swift package warnings
af8b6f2
@goergisn
Renaming and better warning formatting
0fb4684
@goergisn
Merge branch 'surface-swift-package-warnings' into improving-project-…
d509586 
…analyzer

# Conflicts:
#	Sources/Pipeline/Modules/SwiftPackageFileAnalyzer.swift
#	Sources/Pipeline/Pipeline.swift
#	Tests/UnitTests/PipelineTests.swift
#	Tests/UnitTests/SwiftPackageFileAnalyzerTests.swift
@goergisn goergisn changed the base branch from main to surface-swift-package-warnings September 13, 2024 13:24
@goergisn goergisn added the enhancement Indicates new feature requests label Sep 13, 2024
@goergisn goergisn linked an issue Sep 13, 2024 that may be closed by this pull request
Surface dependency changes in the Package.swift #12
Closed
Base automatically changed from surface-swift-package-warnings to main September 13, 2024 13:35
@goergisn
Merge branch 'main' into improving-project-analyzer
db37d25 
# Conflicts:
#	Sources/Pipeline/Modules/SwiftPackageFileAnalyzer.swift
#	Sources/Pipeline/Pipeline.swift
#	Tests/UnitTests/PipelineTests.swift
#	Tests/UnitTests/SwiftPackageFileAnalyzerTests.swift
atmamont
atmamont approved these changes Sep 17, 2024
View reviewed changes
Copy link

@atmamont atmamont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't change the flow diagram, does it?

nauaros
nauaros approved these changes Sep 19, 2024
View reviewed changes
@goergisn goergisn merged commit b4a4010 into main Sep 19, 2024
1 check passed
@goergisn goergisn deleted the improving-project-analyzer branch September 19, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmamont atmamont atmamont approved these changes

@nauaros nauaros nauaros approved these changes

@erenbesel erenbesel Awaiting requested review from erenbesel

Assignees
No one assigned
Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Surface dependency changes in the Package.swift
3 participants
@goergisn @nauaros @atmamont