-
Notifications
You must be signed in to change notification settings - Fork 116
[PaymentsAPIs] Code generation: update services and models #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces an automated update to the Payments APIs, specifically regenerating service and model files based on recent changes to the OpenAPI specification. The primary functional change involves modifying how invalid enum values are handled, transitioning from throwing exceptions to logging errors. Additionally, the update includes minor code style improvements and corrections to documentation comments across various PHP files, ensuring the SDK remains aligned with the latest API definitions and best practices.
Highlights
- Error Handling Change: The SDK's behavior for handling invalid enum values has been updated across numerous models. Instead of throwing an
InvalidArgumentException, the system will now log an error usingerror_log. This change affects various fields such asshopperInteraction,contract,tokenService,resultCode,cardProductId,fraudResultType,fraudRiskLevel,recurringProcessingModel,tokenizationStoreOperationType,entityType,loadType, andstatusin different API models. - Code Style and Formatting Improvements: Minor code style and formatting adjustments have been applied to several
ObjectSerializer.phpfiles, including changes toforeachloop syntax and single-lineifstatements. Additionally, documentation comments for@paramtags and@deprecatedannotations received minor spacing corrections, and some empty lines were removed or added for consistency. - Documentation Update for Line Items: The documentation for the
lineItemsparameter in various Checkout API requests and responses (e.g.,CreateCheckoutSessionRequest,PaymentLinkRequest) has been refined. Specifically, 'Zip.' has been removed from the list of payment methods that require this field, reflecting updated requirements or supported payment methods.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated code generation based on an OpenAPI spec update. The most significant change is the modification of the error handling strategy for invalid enum values, switching from throwing exceptions to logging errors. This is a critical change that could lead to silent failures and should be carefully reviewed. Additionally, there are several changes that introduce inconsistencies and violate PSR-12 coding standards, such as incorrect spacing in foreach loops, single-line if statements, and missing blank lines after namespace declarations. I have provided specific comments and suggestions to address these issues.
|



Regenerate models after channging the Mustache templates #807
OpenAPI spec files or templates have been modified on 14-08-2025 by commit.