AcsWebhooks: remove custom fix

[gcatanese]

Remove custom check that was necessary for AcsWebhook RelayedAuthenticationRequest.

The webhook schema provides now the attribute type with the event code necessary for the deserialization.
Test has been updated accordingly.

[gemini-code-assist]

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the BankingWebhookParser by removing a custom workaround previously required for RelayedAuthenticationRequest webhooks. The change is possible because the AcsWebhook schema now consistently provides a type attribute, allowing RelayedAuthenticationRequest to be deserialized using the standard type-based parsing logic.

Highlights

• Simplified Webhook Parsing: The custom if condition that specifically identified RelayedAuthenticationRequest based on id and paymentInstrumentId has been removed from BankingWebhookParser.php.
• Standardized Type-Based Identification: RelayedAuthenticationRequest webhooks are now correctly identified and deserialized by checking their type attribute, aligning with the parsing mechanism used for other webhook events.
• Updated Test Data: The testRelayedAuthenticationRequest in NotificationTest.php has been updated to reflect the new AcsWebhook schema, including the type, environment, and timestamp fields in the test JSON payload.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the custom handling for AcsWebhook RelayedAuthenticationRequest and treats it like other webhooks, which is a good simplification. The accompanying test update is also appropriate.

My review includes a critical fix for a typo in a method call that would cause a fatal error. I've also included a suggestion to refactor the webhook parsing logic to improve maintainability and make it easier to add new webhook types in the future.

[gemini-code-assist]

There's a typo on line 44: the method is called deserializeWebhook, not deserializewebhook. This will cause a fatal error as the method does not exist.

Additionally, this series of if statements is becoming hard to maintain. Many of the existing calls in this method also have typos or use self:: incorrectly for a non-static method. A refactor would be beneficial.

Consider refactoring to a more data-driven approach by iterating over a list of webhook classes. This would fix all the issues at once and make the code cleaner and easier to extend.

Example of refactoring:

private const WEBHOOK_MODEL_CLASSES = [
    AuthenticationNotificationRequest::class,
    RelayedAuthenticationRequest::class,
    BalanceAccountBalanceNotificationRequest::class,
    // ... other classes
];

// in getGenericWebhook()
foreach (self::WEBHOOK_MODEL_CLASSES as $class) {
    $clazz = new $class();
    if (in_array($type, $clazz->getTypeAllowableValues())) {
        return (object)$this->deserializeWebhook($clazz);
    }
}

        if (in_array($type, ($clazz = new RelayedAuthenticationRequest())->getTypeAllowableValues())) {
            return (object)$this->deserializeWebhook($clazz);
        }

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud