-
Notifications
You must be signed in to change notification settings - Fork 116
[PaymentsAPIs] Code generation: update services and models #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces an automated update to the Payments APIs, focusing on code generation enhancements. The primary goal is to modernize the PHP codebase by removing global namespace prefixes from interface implementations and applying minor code style adjustments. These changes improve code consistency and maintainability, ensuring the generated models adhere to current best practices.
Highlights
- PHP Namespace Modernization: I have updated the generated PHP models across various API modules (BinLookup, Checkout, Disputes, Payments) to remove the global namespace prefix (the backslash
\) fromArrayAccessandJsonSerializableinterface implementations. This aligns the codebase with modern PHP coding standards and improves readability. - Code Style Refinements: I have applied minor code style improvements within the
ObjectSerializer.phpfiles in the BinLookup, Checkout, Disputes, and Payments modules. These changes include simplifying conditional statements andforeachloop syntax for cleaner and more concise code. - PHPDoc Formatting Improvements: I have corrected PHPDoc formatting for parameter types in several Checkout models, specifically within
CheckoutPaymentMethod.php,MbwayDetails.php, andVippsDetails.php. This ensures consistency and accuracy in the documentation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request contains auto-generated code from OpenAPI specs. The changes are mostly stylistic updates to use statements and PHPDoc comments, which improve consistency. However, I've found a few violations of the PSR-12 coding standard in the generated ObjectSerializer.php files, related to control structure spacing and the use of braces. I've also noticed some minor formatting issues like trailing spaces in PHPDoc comments in other files. Addressing these in the generator will improve the quality of future generated code.
OpenAPI spec files or templates have been modified on 08-08-2025 by commit.
What has changed
Regenerate source code after PR #797 (update Mustache template to remove leading backslash)