[PaymentsAPIs] Code generation: update services and models #789

AdyenAutomationBot · 2025-08-05T14:09:13Z

OpenAPI spec files or templates have been modified on 06-08-2025 by commit.

Checkout API:

Added support for PayToPaymentMethod and UPIPaymentMethod
Added support for validateShopperId utility to validate the shopper id
Added enum RIVERTY_INSTALLMENTS in RivertyDetails

gemini-code-assist

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated code generation update to the Payments APIs. It primarily focuses on synchronizing the codebase with the latest OpenAPI specification, introducing new models for enhanced payment processing and error handling, and refining existing documentation. The changes ensure the API remains up-to-date with new features and compliance requirements, particularly concerning 3D Secure 2 authentication and payment method types.

Highlights

New API Models and Error Handling: This pull request introduces several new models related to payment methods and shopper ID validation, including DefaultErrorResponseEntity, InvalidField, PayToPaymentMethod, ShopperIdPaymentMethod, UPIPaymentMethod, ValidateShopperIdRequest, and ValidateShopperIdResponse. These additions enhance the API's capability to handle new payment flows and provide more structured error reporting.
New Shopper ID Validation Endpoint: The UtilityApi now includes a new endpoint, validateShopperId, which allows for the validation of shopper IDs. This new functionality supports improved security and compliance measures within payment processing.
Code Style Refinements and Payment Method Expansion: Across various ObjectSerializer.php files, minor code style adjustments have been applied to foreach loops and sanitizeTimestamp methods, ensuring consistency and adherence to coding standards. Additionally, the RivertyDetails model now supports a new riverty_installments type, expanding payment options.
Comprehensive Documentation and Parameter Clarification: Extensive updates have been made to documentation comments across numerous files. These updates primarily involve correcting and standardizing API explorer links, refining descriptions for parameters like shopperEmail, shopperIP, and telephoneNumber to reflect current 3D Secure 2 requirements, and clarifying details for cc and subscriber phone number fields. Deprecation comments in RecurringApi.php have also been updated for consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates services and models based on recent changes to the OpenAPI specification. The changes include adding new models, updating documentation, and modifying existing code. My review focuses on coding standards and potential issues in the generated code. I've identified several violations of PSR-12 coding standards in the ObjectSerializer.php files, specifically related to control structures (foreach and if). While these are likely from the code generator, they should be addressed to maintain code quality and consistency.

gemini-code-assist · 2025-08-05T14:12:20Z

src/Adyen/Model/BinLookup/ObjectSerializer.php

                }
            } else {
-                foreach ($data as $property => $value) {
+                foreach($data as $property => $value) {


According to PSR-12, there must be one space after the control structure keyword. The foreach statement should have a space after it for better readability and to adhere to coding standards.

foreach ($data as $property => $value) {

gemini-code-assist · 2025-08-05T14:12:21Z

src/Adyen/Model/BinLookup/ObjectSerializer.php

-        if (!is_string($timestamp)) {
-            return $timestamp;
-        }
+        if (!is_string($timestamp)) return $timestamp;


According to PSR-12, the body of each structure MUST be enclosed in braces. This if statement should use braces for its body to improve readability and prevent potential issues when adding more code to the block.

if (!is_string($timestamp)) { return $timestamp; }

gemini-code-assist · 2025-08-05T14:12:21Z

src/Adyen/Model/Checkout/ObjectSerializer.php

                }
            } else {
-                foreach ($data as $property => $value) {
+                foreach($data as $property => $value) {


According to PSR-12, there must be one space after the control structure keyword. The foreach statement should have a space after it for better readability and to adhere to coding standards.

foreach ($data as $property => $value) {

gemini-code-assist · 2025-08-05T14:12:21Z

src/Adyen/Model/Checkout/ObjectSerializer.php

-        if (!is_string($timestamp)) {
-            return $timestamp;
-        }
+        if (!is_string($timestamp)) return $timestamp;


According to PSR-12, the body of each structure MUST be enclosed in braces. This if statement should use braces for its body to improve readability and prevent potential issues when adding more code to the block.

if (!is_string($timestamp)) { return $timestamp; }

gemini-code-assist · 2025-08-05T14:12:21Z

src/Adyen/Model/Disputes/ObjectSerializer.php

                }
            } else {
-                foreach ($data as $property => $value) {
+                foreach($data as $property => $value) {


According to PSR-12, there must be one space after the control structure keyword. The foreach statement should have a space after it for better readability and to adhere to coding standards.

foreach ($data as $property => $value) {

gemini-code-assist · 2025-08-05T14:12:23Z

src/Adyen/Model/PosMobile/ObjectSerializer.php

-        if (!is_string($timestamp)) {
-            return $timestamp;
-        }
+        if (!is_string($timestamp)) return $timestamp;


According to PSR-12, the body of each structure MUST be enclosed in braces. This if statement should use braces for its body to improve readability and prevent potential issues when adding more code to the block.

if (!is_string($timestamp)) { return $timestamp; }

gemini-code-assist · 2025-08-05T14:12:23Z

src/Adyen/Model/Recurring/ObjectSerializer.php

                }
            } else {
-                foreach ($data as $property => $value) {
+                foreach($data as $property => $value) {


According to PSR-12, there must be one space after the control structure keyword. The foreach statement should have a space after it for better readability and to adhere to coding standards.

foreach ($data as $property => $value) {

gemini-code-assist · 2025-08-05T14:12:23Z

src/Adyen/Model/Recurring/ObjectSerializer.php

-        if (!is_string($timestamp)) {
-            return $timestamp;
-        }
+        if (!is_string($timestamp)) return $timestamp;


According to PSR-12, the body of each structure MUST be enclosed in braces. This if statement should use braces for its body to improve readability and prevent potential issues when adding more code to the block.

if (!is_string($timestamp)) { return $timestamp; }

gemini-code-assist · 2025-08-05T14:12:23Z

src/Adyen/Model/StoredValue/ObjectSerializer.php

                }
            } else {
-                foreach ($data as $property => $value) {
+                foreach($data as $property => $value) {


According to PSR-12, there must be one space after the control structure keyword. The foreach statement should have a space after it for better readability and to adhere to coding standards.

foreach ($data as $property => $value) {

gemini-code-assist · 2025-08-05T14:12:23Z

src/Adyen/Model/StoredValue/ObjectSerializer.php

-        if (!is_string($timestamp)) {
-            return $timestamp;
-        }
+        if (!is_string($timestamp)) return $timestamp;


According to PSR-12, the body of each structure MUST be enclosed in braces. This if statement should use braces for its body to improve readability and prevent potential issues when adding more code to the block.

if (!is_string($timestamp)) { return $timestamp; }

sonarqubecloud · 2025-08-06T07:47:35Z

Quality Gate passed

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
92.2% Duplication on New Code

See analysis details on SonarQube Cloud

AdyenAutomationBot requested a review from a team as a code owner August 5, 2025 14:09

gemini-code-assist bot reviewed Aug 5, 2025

View reviewed changes

AdyenAutomationBot force-pushed the sdk-automation/PaymentsAPIs branch from cb45de4 to a13d26a Compare August 5, 2025 14:28

[reformat][adyen-sdk-automation] automated changes

b65daf3

AdyenAutomationBot force-pushed the sdk-automation/PaymentsAPIs branch from a0e3b7a to b65daf3 Compare August 6, 2025 07:40

style(fmt): code formatted

154ede3

gcatanese approved these changes Aug 6, 2025

View reviewed changes

gcatanese added the Feature label Aug 6, 2025

gcatanese merged commit 8790b75 into main Aug 6, 2025
10 checks passed

gcatanese deleted the sdk-automation/PaymentsAPIs branch August 6, 2025 12:34

AdyenAutomationBot mentioned this pull request Aug 6, 2025

Release v28.2.0 #776

Merged

[PaymentsAPIs] Code generation: update services and models #789

[PaymentsAPIs] Code generation: update services and models #789

Uh oh!

Conversation

AdyenAutomationBot commented Aug 5, 2025 • edited by gcatanese Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checkout API:

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 6, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AdyenAutomationBot commented Aug 5, 2025 •

edited by gcatanese

Loading