Skip to content

Conversation

@gcatanese
Copy link
Contributor

Adding unit tests to verify:

  • additional response attributes don't thrown an exception
  • unknown response enums don't thrown an exception: this fails. Test is skipped until the enum parsing will be corrected

@gcatanese gcatanese requested a review from a team as a code owner July 2, 2025 11:31
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the robustness of the API client by introducing new unit tests. These tests aim to ensure the client can gracefully handle unexpected data in API responses, specifically by not throwing exceptions when encountering additional, unknown attributes or unrecognized enum values. One of the tests highlights a current limitation in enum parsing, which is noted and skipped for future resolution.

Highlights

  • API Client Robustness (Additional Attributes): Added a new unit test (testGetAccountHolderAdditionalAttributesDoesNotThrow) to verify that the API client does not throw exceptions when encountering unexpected, additional attributes in a getAccountHolder response. This ensures the client can gracefully handle future API extensions.
  • API Client Robustness (Unknown Enums): Introduced a unit test (testGetAccountHolderUnknownEnum) to check the client's behavior with unknown enum values in API responses. This test is currently skipped, as indicated by the author, due to an existing issue with enum parsing that needs to be addressed.
  • New Baseline Test: Added a basic testGetAccountHolder unit test to validate the standard parsing of an AccountHolder response, providing a foundational test for the Balance Platform API.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds unit tests to verify the deserialization behavior for API responses containing unknown attributes or enum values. I've identified a bug in an assertion for a skipped test. Overall, this is a good addition for improving the robustness of the client library.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2025

@gcatanese gcatanese merged commit 8772d6c into main Jul 2, 2025
9 checks passed
@gcatanese gcatanese deleted the test-unknown-enums branch July 2, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants