Skip to content

Conversation

@gcatanese
Copy link
Contributor

The live url of the SessionAuthentication API is incorrect: this PR fixes the bug and adds a test.

This is a short-term solution, we will revise the approach and use the url from the OpenAPI servers element.

Fix #1577

@gcatanese gcatanese requested review from a team as code owners October 23, 2025 13:39
@gcatanese gcatanese added the Fix Indicates a bug fix label Oct 23, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug concerning the SessionAuthentication API's live endpoint URL. It implements a direct fix within the createBaseURL method to ensure the correct live URL is generated from its test equivalent. To guarantee the integrity of this change, a new unit test has been added. The author indicates this is an immediate fix, with a more comprehensive, long-term strategy involving OpenAPI specifications planned for future implementation.

Highlights

  • Fixes SessionAuthentication Live URL: Corrects the live URL for the SessionAuthentication API, which was previously incorrect.
  • Adds New Test Case: Introduces a dedicated test (testSessionAuthenticationLiveUrl) to verify the accurate transformation of the SessionAuthentication API's test URL to its live counterpart.
  • Short-Term Solution: Notes that this fix is a temporary measure, with a future plan to derive URLs from the OpenAPI servers element for a more robust solution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an incorrect URL for the SessionAuthentication API and includes a test case to verify the fix. The change involves adding a specific case to replace the test URL with the live URL for the /authe/ endpoint in the createBaseURL method. A corresponding test case has been added to ServiceTest.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Indicates a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SessionAuthentication baseUrl is incorrect

3 participants