-
Notifications
You must be signed in to change notification settings - Fork 146
Code generation: update services and models #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0b26070 to
7f36639
Compare
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Adyen services and models, ensuring that the codebase remains synchronized with the latest OpenAPI specification. The changes are primarily focused on maintaining code quality and consistency through reordering imports, refining Javadoc comments, and adjusting whitespace, reflecting an evolution in the underlying API definitions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by an OpenAPI tool, introduces widespread formatting changes across numerous model and service files. While many changes are stylistic (like indentation), some have introduced inconsistencies and reduced code readability. My review focuses on these recurring patterns, with specific examples provided in the comments. Key areas for improvement include:
- Refactoring verbose logic in
AcsWebhooksHandlerto use a more concise, functional style. - Reformatting single-line method implementations for better readability.
- Correcting improperly formatted empty constructors and Javadoc comments.
Addressing these patterns across the codebase will improve maintainability and adherence to standard Java conventions.
c8b87b5 to
858a402
Compare
5a0d345 to
e3418c9
Compare
Add in
Recurringnew enumsONECLICK_RECURRING,EXTERNALin BinLookup/Checkout/Payout, however those enums are not used by the API (skip from Release Notes).OpenAPI spec files or templates have been modified on 26-09-2025 by commit.