TerminalCommonNameValidator: Update validation regex

[gcatanese]

PR to update the regex validation of the Common Name of a terminal API certificate.

The updated validation regex supports a new format CN={letters or numbers}-{letters or numbers}.{environent}.terminal.adyen.com, for example to allow:

• CN=TG300-G10M123M12345.test.terminal.adyen.com

[gemini-code-assist]

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the validation mechanism for Common Names within terminal API certificates. The primary goal is to accommodate a broader range of certificate naming conventions by allowing alphanumeric characters in a specific part of the CN, which was previously restricted to numerical values. This change ensures future compatibility and strengthens the robustness of certificate validation, complemented by improved code documentation.

Highlights

• Regex Update for Common Name Validation: The regular expression used to validate the Common Name (CN) of terminal API certificates has been updated to support a new format allowing alphanumeric characters in the second segment of the CN (e.g., CN={letters or numbers}-{letters or numbers}).
• Improved Code Documentation: Javadoc comments have been added to the TerminalCommonNameValidator class and its validateCertificate method, enhancing clarity and maintainability.
• Expanded Unit Test Coverage: A new parameterized test case has been introduced to verify the correct validation of the newly supported Common Name format, ensuring the updated regex functions as expected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the regex for validating the Common Name of a terminal API certificate to support a new format. The change itself is correct and is accompanied by a new test case. My review focuses on improving the code quality and performance. The changes in the test file include significant formatting adjustments (indentation changes) which create some noise in the diff; this is something to be mindful of for future changes.

I've identified a few areas for improvement in TerminalCommonNameValidator.java:

• The Javadoc formatting can be cleaned up by removing some unusual characters and making parameter descriptions more conventional.
• There's a performance concern with how the validation regex is used. It's being recompiled on every validation check. I've suggested a caching strategy to pre-compile the patterns for each environment, which will improve efficiency, especially if this validation is performed frequently.