-
Notifications
You must be signed in to change notification settings - Fork 146
TerminalAPI: PredefinedContentHelper for managing Display Events #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new PredefinedContentHelper class within the TerminalAPI to streamline the parsing and management of Display Notification events from the PredefinedContent->ReferenceID field. This helper simplifies the extraction of event types, transaction IDs, and timestamps from the URL query string formatted ReferenceID, making it easier for developers to handle various display notification scenarios.
Highlights
- New Helper Class: Introduced PredefinedContentHelper to parse ReferenceID strings from PredefinedContent objects.
- Event Enumeration: Added DisplayNotificationEvent enum to map and validate supported display notification types, improving type safety and readability.
- Data Extraction Methods: Provided utility methods (getEvent, getTransactionId, getTimeStamp, get) for safely extracting specific parameters from the parsed ReferenceID using Optional.
- Documentation Update: Updated README.md with a new "Helper classes" section, including a clear code example demonstrating the usage of PredefinedContentHelper.
- Comprehensive Testing: Included PredefinedContentHelperTest with various unit tests to ensure the robustness and correctness of the parsing logic and data extraction methods, covering valid, invalid, and edge cases.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a PredefinedContentHelper to parse display notification events from the ReferenceID field. The implementation is clean and well-tested. I've added a few suggestions to improve maintainability and correctness. The main point is to correct the usage example in the README.md as it refers to a non-existent method. I've also suggested using constants for keys and simplifying the URL decoding logic in the helper class.
src/main/java/com/adyen/model/nexo/PredefinedContentHelper.java
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Provide
PredefinedContentHelperto extract and parseReferenceID.Enums are also defined to map the supported Display notification types.