-
Notifications
You must be signed in to change notification settings - Fork 146
Client setup: remove old code and promote best practises #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the Client object setup within the library. It streamlines the client initialization process by removing outdated methods and standardizing on a Config object for configuration. Additionally, it significantly enhances the codebase's documentation through Javadoc additions and updates the public-facing README to guide users towards these new best practices, ultimately leading to a more robust and user-friendly client integration.
Highlights
- Code Cleanup and Modernization: Removed several legacy and deprecated
Clientconstructors and thesetEnvironmentmethod, simplifying the API surface and promoting current best practices. - Configuration Standardization: Promoted the use of the
Configobject forClientsetup, allowing for a more structured and flexible way to configure the client, as demonstrated in updatedREADME.mdexamples andClientTest. - Improved Documentation: Added comprehensive Javadoc comments to the
Client,Service, andConfigclasses, enhancing code clarity and maintainability for developers. - Documentation Updates: Updated the
README.mdto reflect the newClientsetup best practices, including examples for API key and basic authentication, and added a new section on error handling. - Enhanced Test Coverage: Introduced a new
ServiceTest.javafile with dedicated unit tests for theService.createBaseURLmethod, ensuring correct URL construction across different environments and API types.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does a great job of cleaning up the client setup by removing deprecated methods, adding Javadoc, and updating documentation to reflect best practices. The changes significantly improve the library's usability. My review focuses on a few areas: ensuring code examples in the documentation are self-contained, maintaining consistent code formatting across the project, and adopting more modern testing patterns for improved readability.
This PR improves the setup of the
Clientobject required to perform the API requests. The following changes have been introduced:ClientTestto show case best practises for setting up theClientobjectClient,ServiceandConfigclassesREADMEto show case best practises for setting up theClientobject