Skip to content

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jul 16, 2024

Purpose of this pull request

This pull request (PR) Add content for explain code recent added

Affected pages

Links to Magento Open Source code

Code

@jeff-matthews jeff-matthews self-assigned this Jul 16, 2024
@jeff-matthews jeff-matthews added the new-topic New original content label Jul 16, 2024
@jeff-matthews jeff-matthews self-requested a review July 16, 2024 13:08
@jeff-matthews
Copy link
Contributor

jeff-matthews commented Jul 16, 2024

Thanks for the PR @mrtuvn!

I confirmed internally that this will be available in the 2.4.8-beta1 release in October. I'm going to create a 2.4.8-develop integration branch in this repo for this before assigning for review.

@jeff-matthews jeff-matthews changed the base branch from main to 2.4.8-develop July 16, 2024 15:06
@jeff-matthews
Copy link
Contributor

Changed base branch to integration branch.

@jeff-matthews
Copy link
Contributor

Hi @mrtuvn,

I just wanted to let you know that I've started reviewing this PR and will have suggestions later this week.

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrtuvn,

What do you think about adding this content to the existing page about CSS and LESS preprocessing? Specifically under the @magento_import directive?

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Aug 19, 2024

updated as your suggestions

@jeff-matthews jeff-matthews added major-update Significant updates to content and removed new-topic New original content labels Aug 19, 2024
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrtuvn! I made some editorial suggestions to align with our style and formatting. It might be difficult to see in the GitHub suggestions, so I'm also attaching a .md file of what the changes should look like.

css-flag.md

@jeff-matthews jeff-matthews changed the base branch from 2.4.8-develop to pr-180-cleanup August 20, 2024 13:08
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrtuvn. I'm going to merge this into a separate integration branch and do the rest of the formatting.

@jeff-matthews jeff-matthews merged commit fb840c9 into AdobeDocs:pr-180-cleanup Aug 20, 2024
3 of 4 checks passed
jeff-matthews added a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.8 major-update Significant updates to content
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants