feat: Implement Ping All feature with right-aligned status indicators #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tan9. Thanks a lot for your contribution! |
Add comprehensive ping functionality: - Add 'G' shortcut to ping all servers simultaneously - Add right-aligned status indicators on server list - Show ping latency with adaptive formatting (<100ms as "##ms", >=100ms as "#.#s") - Responsive design adapts to window width changes - Color-coded status: green (up), red (down), orange (checking) - Update single server ping (g) to also show status
Maintain the current server selection when ping or ping all operations update the server list. Previously, the selection would reset to the first item after each update.
After ping status update, editing server form would incorrectly detect unsaved changes. This fix excludes transient runtime fields (PingStatus, PingLatency) and metadata fields from the comparison logic. - Added struct tags to mark transient and metadata fields in domain.Server - Updated serversDiffer() to skip fields based on struct tags - Fixed goconst warnings by using existing status constants - Added comprehensive tests for the change detection logic
|
@Adembc, I’ve completed the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gto simultaneously check connectivity of all serversg) to display persistent status in the server listChanges
Gto ping all visible servers at onceTesting
Gkey to ping all servers - confirms all servers are pinged simultaneouslygkey for single server ping - updates status correctlyScreenshots
The ping status indicators appear right-aligned at the end of each server entry, providing immediate visual feedback on server connectivity without disrupting the current selection.
Closes #30