Fix Clang Template errors #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2024
kmuseth
requested changes
Dec 3, 2024
Upcoming versions of Clang/LLVM change some behaviour around templating that causes OpenVDB to fail to compile. This commit addresses two issues and allows VDB to compile again. 1. There were three instances of an unnecessary template keyword in NodeManager.h that were not followed by a template call, and therefore are illegal to the compiler. 2. GridBuilder.h had a template call to a non-existent method. This was not previously validated, but is now validated. Switching the symbol from `isActive` to `isOn` per Ken's review. See the [changelog](https://releases.llvm.org/19.1.0/tools/clang/docs/ReleaseNotes.html#improvements-to-clang-s-diagnostics:~:text=Clang%20now%20looks%20up%20members%20of%20the%20current%20instantiation%20in%20the%20template%20definition%20context%20if%20the%20current%20instantiation%20has%20no%20dependent%20base%20classes.) for Clang and the associated [PR for the second point above](llvm/llvm-project#84050) Signed-off-by: Dhruv Govil <[email protected]>
dgovil
force-pushed
the
1976-clang_template_fixes
branch
from
62c002c to
e3ee850
Compare
|
Can confirm that this PR fixes the issue I have when building Blender with clang19 on linux (reported as #1976). |
kmuseth
approved these changes
Dec 4, 2024
|
@dgovil @kmuseth Thanks for identifying, patching, and landing this one so quickly. We're tracking this one for our next release of OpenUSD in May. I was wondering if there'll be a tagged release or patch we can point to in order to pick up this fix? cc/ @jesschimein |
pixar-oss
pushed a commit
to PixarAnimationStudios/OpenUSD
that referenced
this pull request
Mar 8, 2025
AcademySoftwareFoundation/openvdb#1977 fixed a syntax issue that caused errors when building with Xcode 16.3. This change updates build_usd.py to apply the (simple) patch to the version of OpenVDB it builds. We manually back-port this fix for a few reasons: - The PR was merged in December 2024, but is currently not part of an official release. - build_usd.py currently uses OpenVDB 9.1.0, which is several major versions behind the current latest version 12.0.0. Even if the PR were released in a new 12.x version, we wouldn't want to jump all the way there since it's so far ahead of what we're building and testing against internally. If OpenVDB officially ports the fix back to older versions, we can revert this change and just update build_usd.py to pull in the official release instead. (Internal change: 2359154)
3 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming versions of Clang/LLVM change some behaviour around templating that causes OpenVDB to fail to compile.
This commit addresses two issues and allows VDB to compile again.
There were three instances of an unnecessary template keyword in NodeManager.h that were not followed by a template call, and therefore are illegal to the compiler.
GridBuilder.h had a template call to a non-existent method. This was not previously validated, but is now validated. Switching the call from
isActivetoisOnworks (as suggested by Ken).See the changelog for Clang and the associated PR for the second point above
This fixes #1976
Built on macOS with the following build args