Update RPC Tendermint to 38 #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6278156
|
| Status: | 🚫 Build failed. |
adairrr
commented
Nov 18, 2023
| @@ -11,6 +11,7 @@ use prost::Message; | |||
|
|
|||
| /// Querier for the Tendermint node. | |||
| /// Supports queries for block and tx information | |||
| /// @TODO: all tendermint queries should use the tendermint-rpc explicitly instead of hitting the tendermint node with the typed queries. | |||
There was a problem hiding this comment.
what do you mean ? The tendermint rpc library does not expose those types, so we can't really do that can we ?
There was a problem hiding this comment.
Only when it does expose those types - I think most of them are covered in this PR but there could still be some outstanding ones.
|
Closing because we are not planning on adding RPC support to cw-orch soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes updates the version of
cosmrsfor RPC support in orchestrator. It also fixes some minor bugs when interacting withwasmdv0.50-rc-2.