#17 DataFrameImplicits #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedeki
reviewed
Jan 12, 2022
| * @param schema An optional schema to validate if the column already exists (a very low probability) | ||
| * @return A name that can be used as a unique column name | ||
| */ | ||
| def getUniqueName(prefix: String, schema: Option[StructType]): String = { |
There was a problem hiding this comment.
I would make this an implicit on StructType. When not checked against a schema it's so trivial, I wouldn't event bother making it a common function.
There was a problem hiding this comment.
It can be removed since it will be replaced by this
There was a problem hiding this comment.
Not sure how the linked code solves for the need of unique column name? 🤔
Comment on lines
83
to
84
| log.warn(s"Column '$colName' already exists. The content of the column will be overwritten.") | ||
| overwriteWithErrorColumn(df, colName, colExpr) |
There was a problem hiding this comment.
This again is pretty Encaladus specific. I would make this branch of code and input parameter.
ifExists: (DataFrame, String) => Unit = (_, _) => {}This would also eliminate the need for the specific errorColumn code
There was a problem hiding this comment.
So remove all the overwriteWithErrorColumn function?
src/main/scala/za/co/absa/spark/commons/schema/SchemaUtils.scala
Outdated
Show resolved
Hide resolved
…e-implicits # Conflicts: # README.md
benedeki
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17