Feature/merging develop ver.30 #1752
Conversation
* Create license_check.yml
* Add e2e tests into examples * Fix style * Examples - Fix comments * Apply suggestions from code review Co-authored-by: veprokendlo <[email protected]> * Update vars in test jasons and other small fixes * new test for MappingCR and other small fixes * repair key address * typo remove * add recordId conf into test jasons and update readme Co-authored-by: veprokendlo <[email protected]> Co-authored-by: Veronika Huvarova <[email protected]> Co-authored-by: Veronika <[email protected]>
* 1648 GroupExplode and Broadcast working with multiple outputs
* #1648 Multiple outputs in UI and additional output encoding
% Conflicts: % data-model/src/main/scala/META-INF/MANIFEST.MF % menas-web/ui/components/dataset/conformanceRule/MappingConformanceRule/targetSchemaFieldSelector.fragment.xml % menas/ui/index.html
dk1844
requested review from
AdrianOlosutean,
DzMakatun,
HuvarVer,
benedeki and
lokm01
as code owners
| ARG DOCKER_BASE_ARTIFACT=nginx | ||
| ARG DOCKER_BASE_TAG=1-alpine | ||
|
|
||
| FROM ${DOCKER_BASE_ARTIFACT}:${DOCKER_BASE_TAG} |
There was a problem hiding this comment.
I know this is a new feature that people are excited about, but I think it was mainly created for multi staged builds.
What does it give us here? What are the pros of this approach? I honestly see only possible problems here + the extra (undeclared) properties in Maven.
There was a problem hiding this comment.
if DOCKER_BASE_ARTIFACT and DOCKER_BASE_TAG empty, will be using default values in Dockerfile .
I use these ARG in CodeBuild
DOCKER_BASE_ARTIFACT = ECR/bigdatarnd_tomcat
DOCKER_BASE_TAG = needed version
instead of pulling tomcat from DockerHub , I use an image from ECR. Also it the way to avoid an error about "dockerhub limits" https://docs.docker.com/docker-hub/download-rate-limit/ (In Codebuild I meet the error pretty often )
There was a problem hiding this comment.
I would put a comment in there above the ARGVs as to why it is like that.
…d from SparkJobs on execution (#1740) #1702: Different verification of Dataset properties from setup API and from SparkJobs on execution * Essentiality Mandatory received a boolean parameter allowRun * Dataset validation enhanced to support the Mandatory essentiality based on its boolean parameter * Created ValidationKind enumeration with its Spring converter from Spring too * Added query params to dataset validation API to specify how strict the validation should be * Spring RestExceptionHandler changed to return 400 on wrong Query param conversion from string * Essentiality changed to look little more as an enumeration of case objects * String implicits: emptyOrElse, coalesce * UTs * Small code changes * fixed `RunRepositoryIntegrationSuite` not to be local time zone dependent Co-authored-by: Daniel K <[email protected]>
…velop-ver.30 # Conflicts: # menas/src/main/scala/za/co/absa/enceladus/menas/MvcConfig.scala
|
#1740 merged into |
|
SonarCloud Quality Gate failed.
|
This is essentially merging
developintodevelop-ver3.0, but since it was non-trivial, this PR was created.