Skip to content

Conversation

searbe
Copy link

@searbe searbe commented Sep 7, 2018

It took a while to get back around to this - only just got around to spinning up a real CosmosDB instance. The resource name needs to match filename's case too - tests against a real CosmosDB instance will fail without this.

Hope this didn't cause any headaches - although I suppose not on case-insensitive file systems. Do you make use of this project in production at ASOS?

Now it builds and, crucially, all the tests pass on Ubuntu 🚀 🐧

(This is only true for the netcoreapp2.0 tests - the net452 tests via mono will fail at runtime due to issue #7410 since DefaultTrace from Microsoft.Azure.DocumentDb is hard-coupled with EventProviderTraceListener.)

@asosMikeGore
Copy link

Thanks for the PR. I am looking to drop support for net452 but waiting on feedback from our internal consumers, once this is done I am looking to see if we can get this building on Linux build agents.

We do make use of this project in a number of different services, but this is being used in Windows environments only which is why this hasn't been picked up.

@asosMikeGore asosMikeGore reopened this Sep 13, 2018
@asosMikeGore asosMikeGore merged commit cc5499a into ASOS:master Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants