Obtain a version automatically #29
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this macro, and version, checked into the repo, it also makes it hard to acheive the ideal of "tag to release" (because the contents of the repo would have to change at the same time as tagging). Mbed OS didn't use this macro. Given the macro is likely unused, and we only use it internally to share with the host what client version is running, remove the version macro from the public API.
Attempt to determine a version automatically using git. Fallback to v0.0.0 if the version can't be determined (e.g. due to git error, or if the library is not from a git repo). This makes it easier to tag-to-release as we don't have to edit a file at the same time we make a tag: no repository contents need change when making a release.
Contributor
Author
|
This probably doesn't work very well for |
Contributor
This should be OK with find_package, the version will be written to the package version file at export/install time. The only thing is you would need to run your CMake configure and CMake install commands from the repo so |
Contributor
Author
|
Interesting, I'll need to add a commit to add some find_package() testing to this PR and see how well it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to determine a version automatically using git. Fallback to
v0.0.0 if the version can't be determined (e.g. due to git error, or if
the library is not from a git repo).
This makes it easier to tag-to-release as we don't have to edit a file
at the same time we make a tag: no repository contents need change when
making a release.