Support parent project buildVerson in build.gradle #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmisler
approved these changes
Apr 18, 2019
There was a problem hiding this comment.
Tested on Android with RN 0.58.5 and it works great. @alvaromb, what's the chance we can merge and deploy this? It'll save me from having to fork my own version.
alvaromb
approved these changes
Apr 23, 2019
|
I'm waiting for this to be deployed too? Any updates? |
|
@derekmisler unfortunately I cannot get a slot to work on this due to my current schedule. I gave you write access as a collaborator. Please ping me once I can make a release in npm and I'll gladly do it. Thanks. |
|
@derekmisler @alvaromb guys? |
|
Sorry, guys, I must’ve missed that notification from GitHub because I ended up going in a totally different direction. I’ll see what I can do about testing and merging this this weekend |
cunderw
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining the default version, should also support the build version of the parent project.