Skip to content
This repository was archived by the owner on Jul 31, 2025. It is now read-only.

Conversation

@DevquasarX9
Copy link
Member

  • Update method parameters to use more descriptive names
  • Add return type declarations to methods in MongoDbSessionHandler
  • Require the ext-mongodb extension in composer.json

@DevquasarX9 DevquasarX9 requested a review from spont4e February 4, 2025 14:56
…ype safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement.
@DevquasarX9 DevquasarX9 force-pushed the refactor-method-signatures-in-MongoDbSessionHandler branch from 0a86e5c to 9c510dd Compare February 5, 2025 12:06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spont4e spont4e merged commit c34d42f into v5.x Feb 5, 2025
1 check passed
@spont4e spont4e deleted the refactor-method-signatures-in-MongoDbSessionHandler branch February 5, 2025 13:56
@spont4e spont4e added the bug Something isn't working label Feb 5, 2025
spont4e pushed a commit that referenced this pull request Feb 5, 2025
…ype safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)
DevquasarX9 added a commit that referenced this pull request Feb 5, 2025
…ype safety. (#24)

* Refactor method signatures in MongoDbSessionHandler for clarity and type safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)

* Changed package version

---------

Co-authored-by: Ivelin Ivanov <[email protected]>
spont4e pushed a commit that referenced this pull request Feb 5, 2025
…ype safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)
DevquasarX9 added a commit that referenced this pull request Feb 5, 2025
…ype safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23) (#26)

Co-authored-by: Ivelin Ivanov <[email protected]>
DevquasarX9 added a commit that referenced this pull request Apr 28, 2025
…ype safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)
DevquasarX9 added a commit that referenced this pull request Apr 28, 2025
…ype safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)
DevquasarX9 added a commit that referenced this pull request Apr 29, 2025
…ype safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)
DevquasarX9 added a commit that referenced this pull request May 19, 2025
* Added support for Laravel 10.x (#15)

* Updated mongodb/laravel-mongodb package (#16)

* Refactor method signatures in MongoDbSessionHandler for clarity and type safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)

* V5.x rebase (#25)

* v5.x to master (#17)

* Added support for Laravel 10.x (#15)

* Updated mongodb/laravel-mongodb package (#16)
# Conflicts:
#	composer.json

* Update laravel mongodb to rc1 (#18)

* Added support for Laravel 10.x (#15)

* Updated mongodb/laravel-mongodb package (#16)

* Updated mongodb/laravel-mongodb to rc1.

* Updated mongodb/laravel-mongodb to stable version 4. (#19)

* Changed package version

* Update deprecated MongoDB read preference constants to use current values (#28)

* Update deprecated MongoDB read preference constants to use current values

* Bump version to 5.0.5 in composer.json for updated dependencies

* Update session testing suite, add MongoDB test cases, and configure PHPUnit

- Enhance `.gitignore` to exclude `.phpunit.cache`.
- Update GitHub workflow to include Testbench version for Laravel 10.x.
- Create new feature tests: `TestHelperIntegrationTest`, `HttpSessionTest`, and `MongoDbSessionHandlerTest` to validate session handling with MongoDB.
- Refactor MongoDB session command files to remove unnecessary docblocks.
- Document testing process in `README.md`, including setup and expected results.
- Add basic PHPUnit configuration file.
- Define session environment in the base `TestCase`.
- Ensure session operations like reading, writing, and destruction are tested against MongoDB.

* Update GitHub Actions workflow to use MongoDB 7 and improve caching

- Add MongoDB 7 service to CI workflow
- Upgrade checkout action to v3
- Include MongoDB extension in PHP setup
- Implement Composer dependency caching for faster builds
- Modify composer install command for better performance
- Set environment variables for MongoDB connection during test execution
- Update README.md to reflect changes in the CI process

* Remove deprecated MongoDB version constraint from composer.json

* Update mongodb/laravel-mongodb package to version 5.0 in composer.json (#27)

* Update mongodb/laravel-mongodb package to version 5.0 in composer.json

* Update MongoDB commands and improve session handling

Refactor the command to use `getDatabase()` instead of `getMongoDB()`. Update payload access in `MongoDbSessionHandler` from array syntax to object syntax for better readability. Adjust test assertions to match the new access methodology and ensure compatibility with Carbon instances for expiration and last activity timestamps. Clean up formatting inconsistencies throughout the code.

* Update MongoDB connection method to use getDatabase() instead of getMongoDB() in MongodbSessionIndex command

* Update GitHub Actions workflow to trigger on the master branch

---------

Co-authored-by: Ivaylo Mutafov <[email protected]>
DevquasarX9 added a commit that referenced this pull request May 19, 2025
…ype safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)
DevquasarX9 added a commit that referenced this pull request May 19, 2025
* Added support for Laravel 10.x (#15)

* Updated mongodb/laravel-mongodb package (#16)

* Refactor method signatures in MongoDbSessionHandler for clarity and type safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)

* V5.x rebase (#25)

* v5.x to master (#17)

* Added support for Laravel 10.x (#15)

* Updated mongodb/laravel-mongodb package (#16)
# Conflicts:
#	composer.json

* Update laravel mongodb to rc1 (#18)

* Added support for Laravel 10.x (#15)

* Updated mongodb/laravel-mongodb package (#16)

* Updated mongodb/laravel-mongodb to rc1.

* Updated mongodb/laravel-mongodb to stable version 4. (#19)

* Changed package version

* Update deprecated MongoDB read preference constants to use current values (#28)

* Update deprecated MongoDB read preference constants to use current values

* Bump version to 5.0.5 in composer.json for updated dependencies

* Update session testing suite, add MongoDB test cases, and configure PHPUnit

- Enhance `.gitignore` to exclude `.phpunit.cache`.
- Update GitHub workflow to include Testbench version for Laravel 10.x.
- Create new feature tests: `TestHelperIntegrationTest`, `HttpSessionTest`, and `MongoDbSessionHandlerTest` to validate session handling with MongoDB.
- Refactor MongoDB session command files to remove unnecessary docblocks.
- Document testing process in `README.md`, including setup and expected results.
- Add basic PHPUnit configuration file.
- Define session environment in the base `TestCase`.
- Ensure session operations like reading, writing, and destruction are tested against MongoDB.

* Update GitHub Actions workflow to use MongoDB 7 and improve caching

- Add MongoDB 7 service to CI workflow
- Upgrade checkout action to v3
- Include MongoDB extension in PHP setup
- Implement Composer dependency caching for faster builds
- Modify composer install command for better performance
- Set environment variables for MongoDB connection during test execution
- Update README.md to reflect changes in the CI process

* Remove deprecated MongoDB version constraint from composer.json

* Update mongodb/laravel-mongodb package to version 5.0 in composer.json (#27)

* Update mongodb/laravel-mongodb package to version 5.0 in composer.json

* Update MongoDB commands and improve session handling

Refactor the command to use `getDatabase()` instead of `getMongoDB()`. Update payload access in `MongoDbSessionHandler` from array syntax to object syntax for better readability. Adjust test assertions to match the new access methodology and ensure compatibility with Carbon instances for expiration and last activity timestamps. Clean up formatting inconsistencies throughout the code.

* Update MongoDB connection method to use getDatabase() instead of getMongoDB() in MongodbSessionIndex command

* Update GitHub Actions workflow to trigger on the master branch

* Update Laravel version to 11.x and PHP version to 8.2, adjust workflow and configuration files accordingly

---------

Co-authored-by: Ivaylo Mutafov <[email protected]>
DevquasarX9 added a commit that referenced this pull request May 20, 2025
…ype safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)
DevquasarX9 added a commit that referenced this pull request May 20, 2025
* Added support for Laravel 10.x (#15)

* Updated mongodb/laravel-mongodb package (#16)

* Refactor method signatures in MongoDbSessionHandler for clarity and type safety. Add .editorconfig for consistent coding style across files. Update composer.json to include ext-mongodb requirement. (#23)

* V5.x rebase (#25)

* v5.x to master (#17)

* Added support for Laravel 10.x (#15)

* Updated mongodb/laravel-mongodb package (#16)
# Conflicts:
#	composer.json

* Update laravel mongodb to rc1 (#18)

* Added support for Laravel 10.x (#15)

* Updated mongodb/laravel-mongodb package (#16)

* Updated mongodb/laravel-mongodb to rc1.

* Updated mongodb/laravel-mongodb to stable version 4. (#19)

* Changed package version

* Update deprecated MongoDB read preference constants to use current values (#28)

* Update deprecated MongoDB read preference constants to use current values

* Bump version to 5.0.5 in composer.json for updated dependencies

* Update session testing suite, add MongoDB test cases, and configure PHPUnit

- Enhance `.gitignore` to exclude `.phpunit.cache`.
- Update GitHub workflow to include Testbench version for Laravel 10.x.
- Create new feature tests: `TestHelperIntegrationTest`, `HttpSessionTest`, and `MongoDbSessionHandlerTest` to validate session handling with MongoDB.
- Refactor MongoDB session command files to remove unnecessary docblocks.
- Document testing process in `README.md`, including setup and expected results.
- Add basic PHPUnit configuration file.
- Define session environment in the base `TestCase`.
- Ensure session operations like reading, writing, and destruction are tested against MongoDB.

* Update GitHub Actions workflow to use MongoDB 7 and improve caching

- Add MongoDB 7 service to CI workflow
- Upgrade checkout action to v3
- Include MongoDB extension in PHP setup
- Implement Composer dependency caching for faster builds
- Modify composer install command for better performance
- Set environment variables for MongoDB connection during test execution
- Update README.md to reflect changes in the CI process

* Remove deprecated MongoDB version constraint from composer.json

* Update mongodb/laravel-mongodb package to version 5.0 in composer.json (#27)

* Update mongodb/laravel-mongodb package to version 5.0 in composer.json

* Update MongoDB commands and improve session handling

Refactor the command to use `getDatabase()` instead of `getMongoDB()`. Update payload access in `MongoDbSessionHandler` from array syntax to object syntax for better readability. Adjust test assertions to match the new access methodology and ensure compatibility with Carbon instances for expiration and last activity timestamps. Clean up formatting inconsistencies throughout the code.

* Update MongoDB connection method to use getDatabase() instead of getMongoDB() in MongodbSessionIndex command

* Update GitHub Actions workflow to trigger on the master branch

* Update Laravel version to 12.x in workflows and dependencies

- Rename GitHub Actions workflow for Laravel version 12
- Change branch references from v6.x to v7.x
- Update Laravel dependency from 11.* to 12.*
- Adjust TestBench requirement to version 10.x in composer.json
- Modify README to reflect updated package installation command for Laravel 12.x

* Remove obsolete Laravel 10 test workflow, update PHPUnit schema, and refactor MongoDbSessionHandler

- Delete the GitHub Actions workflow for running Laravel 10 tests as it is no longer needed.
- Update the PHPUnit XML schema location to version 12.0 for compatibility.
- Refactor `MongoDbSessionHandler` class constructor and method signatures to use type hints for improved type safety and clarity.

---------

Co-authored-by: Ivaylo Mutafov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants