Skip to content

Enable Nonce Verification Sniff. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable Nonce Verification Sniff. #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
363c634
Enable Nonce Verification Sniff.
peterwilsoncc Feb 27, 2023
53b05e2
Consider the nonce unslashed and sanitized.
peterwilsoncc Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions 10up-Default/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@

<!-- Allow WP global modification -->
<exclude name="WordPress.WP.GlobalVariablesOverride.Prohibited"/>

<!-- This nonce sniff almost never works right -->
<exclude name="WordPress.Security.NonceVerification.Missing"/>
</rule>

<!-- Sets the minimum supported WP version to 4.7, which is over a year old. -->
Expand All @@ -87,6 +84,24 @@
<!-- Make sure that the proper escaping functions are being used -->
<rule ref="WordPressVIPMinimum.Security.ProperEscapingFunction"/>


<rule ref="WP.Security.ValidatedSanitizedInput">
<properties>
<property name="customUnslashingSanitizingFunctions" type="array">
<!--
Allow checking nonces without sanitization.

WordPress nonces do not include any characters requiring
slashes so can be considered unslashed. The verification
is a character by character comparison to a fixed value
so sanitization is not required as only a valid nonce
string should be allowed to pass.
-->
<element value="wp_verify_nonce" />
</property>
</properties>
</rule>

<!-- Loads the PHP Compatibility ruleset. -->
<rule ref="PHPCompatibilityWP" />

Expand Down