Remove duplicated defaultChainId on wallet request handler #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbanbrook
requested changes
Jun 28, 2023
|
I also fixed |
pkieltyka
reviewed
Jun 28, 2023
| } | ||
|
|
||
| export interface WalletUserPrompter { | ||
| getDefaultChainId(): number |
There was a problem hiding this comment.
btw, just wondering, why do we need getDefaultChainId() on the prompter? The idea of the prompter interface is that these are methods which require "user input" / "user confirmation", so the UI will actually prompt the user to proceed or decline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
defaultNetworkIdfrom the wallet request handler, in its place we use the prompter to query this information directly from the wallet webapp. This avoids duplicating this information, something that could lead to sync issues.