From 47b564b2a79c191b080d07ef0df4cec25b0f2e00 Mon Sep 17 00:00:00 2001 From: Chris Bobbe Date: Tue, 2 Apr 2024 13:02:32 -0700 Subject: [PATCH] login: If web-auth error is PlatformException, show error.message to user Fixes: #609 --- lib/widgets/login.dart | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lib/widgets/login.dart b/lib/widgets/login.dart index ce70671d93..3d7ddba6cc 100644 --- a/lib/widgets/login.dart +++ b/lib/widgets/login.dart @@ -301,10 +301,14 @@ class _LoginPageState extends State { assert(debugLog(e.toString())); if (!mounted) return; final zulipLocalizations = ZulipLocalizations.of(context); - // Could show different error messages for different failure modes. + + String message = zulipLocalizations.errorWebAuthOperationalError; + if (e is PlatformException && e.message != null) { + message = e.message!; + } await showErrorDialog(context: context, title: zulipLocalizations.errorWebAuthOperationalErrorTitle, - message: zulipLocalizations.errorWebAuthOperationalError); + message: message); } finally { setState(() { _inProgress = false; @@ -341,10 +345,14 @@ class _LoginPageState extends State { if (!mounted) return; final zulipLocalizations = ZulipLocalizations.of(context); - // Could show different error messages for different failure modes. + + String message = zulipLocalizations.errorWebAuthOperationalError; + if (e is PlatformException && e.message != null) { + message = e.message!; + } await showErrorDialog(context: context, title: zulipLocalizations.errorWebAuthOperationalErrorTitle, - message: zulipLocalizations.errorWebAuthOperationalError); + message: message); } }