File tree Expand file tree Collapse file tree 1 file changed +6
-1
lines changed Expand file tree Collapse file tree 1 file changed +6
-1
lines changed Original file line number Diff line number Diff line change @@ -349,8 +349,11 @@ class PerAccountStore extends ChangeNotifier with StreamStore, MessageStore {
349349 void unregisterMessageList (MessageListView view) =>
350350 _messages.unregisterMessageList (view);
351351 @override
352- void reconcileMessages (List <Message > messages) =>
352+ void reconcileMessages (List <Message > messages) {
353353 _messages.reconcileMessages (messages);
354+ // TODO(#649) notify [unreads] of the just-fetched messages
355+ // TODO(#650) notify [recentDmConversationsView] of the just-fetched messages
356+ }
354357
355358 final MessageStoreImpl _messages;
356359
@@ -469,6 +472,8 @@ class PerAccountStore extends ChangeNotifier with StreamStore, MessageStore {
469472 _messages.handleMessageEvent (event);
470473 unreads.handleMessageEvent (event);
471474 recentDmConversationsView.handleMessageEvent (event);
475+ // When adding anything here (to handle [MessageEvent]),
476+ // it probably belongs in [reconcileMessages] too.
472477 } else if (event is UpdateMessageEvent ) {
473478 assert (debugLog ("server event: update_message ${event .messageId }" ));
474479 _messages.handleUpdateMessageEvent (event);
You can’t perform that action at this time.
0 commit comments