Skip to content

Commit 8cd5a28

Browse files
committed
sticky_header [nfc]: Cut redundant assert on header size
It's already a fact that the header's size in each dimension is non-negative and finite; the framework asserts that in the `layout` implementation (via debugAssertDoesMeetConstraints). So that includes `headerExtent`; and then `paintedHeaderSize` is bounded to between zero and that value.
1 parent 2c94ff7 commit 8cd5a28

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

lib/widgets/sticky_header.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -558,8 +558,8 @@ class _RenderSliverStickyHeaderList extends RenderSliver with RenderSliverHelper
558558

559559
if (header != null) {
560560
header!.layout(constraints.asBoxConstraints(), parentUsesSize: true);
561-
562561
final headerExtent = header!.size.onAxis(constraints.axis);
562+
563563
final double headerOffset;
564564
if (_headerEndBound == null) {
565565
// The header's item has [StickyHeaderItem.allowOverflow] true.
@@ -570,8 +570,6 @@ class _RenderSliverStickyHeaderList extends RenderSliver with RenderSliverHelper
570570
final paintedHeaderSize = calculatePaintOffset(constraints, from: 0, to: headerExtent);
571571
final cacheExtent = calculateCacheOffset(constraints, from: 0, to: headerExtent);
572572

573-
assert(0 <= paintedHeaderSize && paintedHeaderSize.isFinite);
574-
575573
geometry = SliverGeometry( // TODO review interaction with other slivers
576574
scrollExtent: geometry.scrollExtent,
577575
layoutExtent: geometry.layoutExtent,

0 commit comments

Comments
 (0)