test: Adapt to change in [MenuItemButton.onPressed] logic that broke tests

chrisbobbe · gnprice · commit 38ed6c812def · 2023-07-24T17:23:03.000-07:00
Along with 2f0f469, this is a reminder that it'd be good to get our repo added to Flutter's "customer tests" suite: #239. It's also another reminder among several that it'd be good to pin a precise version of Flutter: #15. Discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20Failing.20tests/near/1615254 Related: #15 Related: #239
diff --git a/test/widgets/action_sheet_test.dart b/test/widgets/action_sheet_test.dart
@@ -100,6 +100,7 @@ void main() {
       final quoteAndReplyButton = findQuoteAndReplyButton(tester);
       check(quoteAndReplyButton).isNotNull();
       await tester.tap(find.byWidget(quoteAndReplyButton!));
+      await tester.pump(); // [MenuItemButton.onPressed] called in a post-frame callback: flutter/flutter@e4a39fa2e
     }
 
     void checkLoadingState(PerAccountStore store, ComposeContentController contentController, {

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,7 @@ void main() {`
`100`	`100`	`final quoteAndReplyButton = findQuoteAndReplyButton(tester);`
`101`	`101`	`check(quoteAndReplyButton).isNotNull();`
`102`	`102`	`await tester.tap(find.byWidget(quoteAndReplyButton!));`
	`103`	`+ await tester.pump(); // [MenuItemButton.onPressed] called in a post-frame callback: flutter/flutter@e4a39fa2e`
`103`	`104`	`}`
`104`	`105`
`105`	`106`	`void checkLoadingState(PerAccountStore store, ComposeContentController contentController, {`