Skip to content

Commit b49879c

Browse files
authored
Make sure that field errors are always visible (#767)
Bootstrap sets `display: none` unless the error comes after an invalid field. Fixes #763 and potentially #749 see #763 (comment)
1 parent 1d9b180 commit b49879c

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{% if field_errors %}
2-
<div id="{{ field.auto_id }}_error">
2+
<div id="{{ field.auto_id }}_error" class="w-100">
33
{% for text in field_errors %}
4-
<div class="invalid-feedback">{{ text }}</div>
4+
<div class="invalid-feedback d-block">{{ text }}</div>
55
{% endfor %}
66
</div>
77
{% endif %}

tests/test_bootstrap_field_input_checkbox.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ def test_input_type_checkbox_is_invalid(self):
3939
'<div class="form-check">'
4040
'<input class="form-check-input is-invalid" id="id_test" name="test" required type="checkbox">'
4141
'<label class="form-check-label" for="id_test">Test</label>'
42-
'<div id="id_test_error">'
43-
'<div class="invalid-feedback">This field is required.</div>'
42+
'<div id="id_test_error" class="w-100">'
43+
'<div class="invalid-feedback d-block">This field is required.</div>'
4444
"</div>"
4545
"</div>"
4646
"</div>"

tests/test_bootstrap_field_input_text.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ def test_input_type_text(self):
4343
'<label class="form-label" for="id_test">Test</label>'
4444
'<input type="text" name="test"'
4545
' class="form-control is-invalid" placeholder="Test" required id="id_test">'
46-
'<div id="id_test_error">'
47-
'<div class="invalid-feedback">This field is required.</div>'
46+
'<div id="id_test_error" class="w-100">'
47+
'<div class="invalid-feedback d-block">This field is required.</div>'
4848
"</div>"
4949
"</div>"
5050
),
@@ -201,8 +201,8 @@ def test_input_validation_failure(self):
201201
'<span class="input-group-text">foo</span>'
202202
'<input type="text" name="test" minlength="1" class="form-control'
203203
' is-invalid" placeholder="Test" required id="id_test">'
204-
'<div id="id_test_error">'
205-
'<div class="invalid-feedback">This field is required.</div>'
204+
'<div id="id_test_error" class="w-100">'
205+
'<div class="invalid-feedback d-block">This field is required.</div>'
206206
"</div>"
207207
"</div>"
208208
"</div>"

0 commit comments

Comments
 (0)