std compiler error fixes pt 2 #25124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnwindError depends on the funciton next_unwind, which depends on the definition of StackIterator which contains an UnwindError Fix by only passing necessary args to next_unwind instead of the whole StackIterator struct
linusg
reviewed
Sep 3, 2025
Collaborator
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
Some minor nits, otherwise LGTM
used to be an union of either Pdb or Dwarf, now it's 2 optional fields for each
Const version doesn't have dedicated field for len, it's stored on the slice
This references deprecated code that was deleted months ago
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20505
progress #21094
+ some misc fixes not tracked by other issues