std.os.linux: Fix bunch of compilation errors #21138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fardragon
force-pushed
the
21094-std-linux-fixes
branch
from
e85bb51 to
febfd18
Compare
alexrp
reviewed
Aug 21, 2024
lib/std/os/linux.zig
Outdated
|
|
||
| /// Wait on a futex. | ||
| /// Identical to `FUTEX.FUTEX_WAIT_BITSET`, except it is part of the futex2 family of calls. | ||
| /// Identical to the traditional FUTEX_WAIT_BITSET op, except it is part of the |
Member
There was a problem hiding this comment.
Nit: Please keep the backticks (futex2 below should really use them as well).
Contributor
Author
There was a problem hiding this comment.
I've restored them. Is it just a stylistic choice or do they serve some kind of purpose? I'm asking out of curiosity.
Member
There was a problem hiding this comment.
Doc comments currently use a subset of Markdown.
Contributor
Author
There was a problem hiding this comment.
Oh right, that makes sense. Thanks
alexrp
approved these changes
Aug 21, 2024
andrewrk
force-pushed
the
21094-std-linux-fixes
branch
from
c11c542 to
a5bd5b2
Compare
andrewrk
approved these changes
Aug 23, 2024
| pub const IntInfo = packed struct(u32) { | ||
| bits: u8, | ||
| unused: u8, | ||
| reserved_1: u8, |
Member
There was a problem hiding this comment.
Suggested change
| reserved_1: u8, | |
| reserved_1: u8 = 0, |
| char = 1 << 1, | ||
| boolean = 1 << 2, | ||
| }, | ||
| reserved_2: u4, |
Member
There was a problem hiding this comment.
Suggested change
| reserved_2: u4, | |
| reserved_2: u4 = 0, |
richerfu
pushed a commit
to richerfu/zig
that referenced
this pull request
Oct 28, 2024
* Correct layout of IntInfo according to https://www.kernel.org/doc/html/latest/bpf/btf.html#btf-kind-int * Fix VFS errors * Fix std.os.linux.sendmmsg * Fix std.os.linux.sigismember. Add tests * Fix futex2 functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the
std.os.linuxcompilation errors reported in #21094