Add getppid to std.c and std.os.linux. #20866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The std lib is missing getppid, this patch adds it.
alexrp
reviewed
Jul 30, 2024
| pub extern "c" fn if_nametoindex([*:0]const u8) c_int; | ||
|
|
||
| pub extern "c" fn getpid() pid_t; | ||
| pub extern "c" fn getppid() pid_t; |
Member
There was a problem hiding this comment.
Note that this doesn't exist on Windows.
I think it's "fine" in that it's no worse than many of the other declarations immediately surrounding it. Just noting that at some point we need to go through and change these declarations to be in line with the principles laid out in #20679. I don't think this necessarily has to block merging this PR, since that conversion work will likely be done in a batched fashion anyway.
alexrp
approved these changes
Aug 7, 2024
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std lib is missing getppid, this patch adds it.