Skip to content

std.os.windows: Support UTF-8 ↔ UTF-16 conversion for Windows native console I/O #16618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

std.os.windows: Support UTF-8 ↔ UTF-16 conversion for Windows native console I/O #16618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7e2ef6
std.os.windows: Support UTF-8 ↔ UTF-16 conversion for Windows native …
Prcuvu Aug 4, 2023
9495568
std.os.windows: Rewrite `ReadConsoleWithUtf16ToUtf8Conversion()` usin…
Prcuvu Aug 6, 2023
045c169
std.os.windows: Remove LF ↔ CRLF conversion in Windows native console…
Prcuvu Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/std/os.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,6 +1068,10 @@ pub const WriteError = error{

/// Connection reset by peer.
ConnectionResetByPeer,

/// This error occurs when trying to write UTF-8 text to a Windows console,
/// and the UTF-8 to UTF-16 conversion fails. Windows-only.
InvalidUtf8,
} || UnexpectedError;

/// Write to a file descriptor.
Expand Down Expand Up @@ -3239,8 +3243,7 @@ pub fn isatty(handle: fd_t) bool {
if (isCygwinPty(handle))
return true;

var out: windows.DWORD = undefined;
return windows.kernel32.GetConsoleMode(handle, &out) != 0;
return windows.IsConsoleHandle(handle);
}
if (builtin.link_libc) {
return system.isatty(handle) != 0;
Expand Down
Loading