std.http.Client ignores uri.query

[billzez]

Zig Version

0.11.0-dev.1507

Steps to Reproduce and Observed Behavior

uri.query is not part of the http header.

Expected Behavior

uri.query is part of the http header.

[billzez]

This kinda feels like a foot-gun. path usually includes the query string. It might make sense to make this more inline with the WHATWG spec:

https://nodejs.org/api/url.html#url-strings-and-url-objects

I propose that std.Uri:

• the path field includes the query string (but not the fragment/hash)
• adds pathname() and query() methods.

@MasterQ32

[ikskuh]

I strongly disagree, as path and query fields are semantically so different that's a footgun to merge them. Especially as std.Uri supports a lot of different styles of uri. Would you expect to be doi:1234?foobar the path to be 1234?foobar instead of 1234?

Imho we should not replicate nodejs, but stick closely to the RFC terms that have well defined path and query properties. Using std.Uri for HTTP is only one use case of many

[billzez]

Understood, looks like Go and Rust follow the RFC (and not WHATWG) as well.

Looking at Go's net/url, it also has requestURI() that combines path+query.

[seiflotfy]

Is this regarding the http/Client.zig Request.Headers struct ?

[truemedian]

This was fixed in #14762.