drivers: led_strip: Various enhancements #71630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedjnK
requested review from
simonguinot
and removed request for
mbolivar-ampere
zephyrbot
added
area: Display
area: Samples
zephyrbot
requested review from
Mani-Sadhasivam,
aescolar,
bbilas,
danieldegrasse,
decsny,
galak,
jfischer-no,
kartben,
mbolivar-ampere,
nashif,
soburi,
vaishnavachath,
vanti and
yonsch
thedjnK
force-pushed
the
ledstripupdates
branch
from
3f4646e to
2967635
Compare
soburi
reviewed
Apr 18, 2024
thedjnK
force-pushed
the
ledstripupdates
branch
from
2967635 to
aeb6fad
Compare
thedjnK
force-pushed
the
ledstripupdates
branch
2 times, most recently
from
f009600 to
c2fdeeb
Compare
soburi
previously approved these changes
May 6, 2024
pdgendt
reviewed
May 7, 2024
aescolar
reviewed
May 7, 2024
aescolar
previously requested changes
May 7, 2024
Member
aescolar
left a comment
aescolar
left a comment
There was a problem hiding this comment.
See comment #71630 (comment)
Adds a common binding with a chain length and colour ordering property Signed-off-by: Jamie McCrae <[email protected]>
Adds chain length and colour mapping properties to LED strip devices on boards where these parameters are now required Signed-off-by: Jamie McCrae <[email protected]>
Adds a length function which returns the length of the LED strip Signed-off-by: Jamie McCrae <[email protected]>
Updates the include file to fix some formatting issues Signed-off-by: Jamie McCrae <[email protected]>
Checks that the supplied length is valid for the given driver before passing it to the update function Signed-off-by: Jamie McCrae <[email protected]>
Makes the update channels function optional, this is only implemented in one driver so can be safely omitted from most drivers Signed-off-by: Jamie McCrae <[email protected]>
Adds changes about the LED strip driver Signed-off-by: Jamie McCrae <[email protected]>
The chain-length DTS property is now mandatory, so remove the optional Kconfig for setting the length Signed-off-by: Jamie McCrae <[email protected]>
simonguinot
approved these changes
May 9, 2024
Contributor
Author
|
ping @soburi |
soburi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various enhancements to the LED strip driver class: