Skip to content

net: shell: Prevent deadlock with net arp command #66518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2023
Merged

net: shell: Prevent deadlock with net arp command #66518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions subsys/net/ip/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,23 @@ config NET_SHELL_DYN_CMD_COMPLETION
length) by default. Other dynamic completion commands in
net-shell require also some smaller amount of memory.

config NET_SHELL_REQUIRE_TX_THREAD
bool
depends on NET_SHELL && (SHELL_BACKEND_TELNET || SHELL_BACKEND_MQTT)
default y if NET_ARP
help
Hidden symbol indicating that network shell requires separate TX
thread due to possible deadlocks during shell/net stack operations.

config NET_TC_TX_COUNT
int "How many Tx traffic classes to have for each network device"
default 1 if USERSPACE || USB_DEVICE_NETWORK
default 1 if USERSPACE || USB_DEVICE_NETWORK || \
NET_SHELL_REQUIRE_TX_THREAD
default 0
range 1 NET_TC_NUM_PRIORITIES if NET_TC_NUM_PRIORITIES<=8 && USERSPACE
range 1 NET_TC_NUM_PRIORITIES if NET_TC_NUM_PRIORITIES<=8 && \
(USERSPACE || NET_SHELL_REQUIRE_TX_THREAD)
range 0 NET_TC_NUM_PRIORITIES if NET_TC_NUM_PRIORITIES<=8
range 1 8 if USERSPACE
range 1 8 if USERSPACE || NET_SHELL_REQUIRE_TX_THREAD
range 0 8
help
Define how many Tx traffic classes (queues) the system should have
Expand Down