Skip to content

Commit ff3b019

Browse files
pfalconjukkar
authored andcommitted
net: shell: Make shell commands non-static to allow reuse.
Some applications may want to reuse implementations of these commands for debugging/diagnostics purpose even if they don't use net shell per se, or implement an alternative shell. Jira: ZEP-2064 Change-Id: I48cb66ccc41bd41a75a4eb8eb3c366316ec5a096 Signed-off-by: Paul Sokolovsky <[email protected]>
1 parent ddf23f3 commit ff3b019

File tree

2 files changed

+37
-24
lines changed

2 files changed

+37
-24
lines changed

subsys/net/ip/net_shell.c

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ static void allocs_cb(struct net_pkt *pkt,
620620

621621
/* Put the actual shell commands after this */
622622

623-
static int shell_cmd_allocs(int argc, char *argv[])
623+
int net_shell_cmd_allocs(int argc, char *argv[])
624624
{
625625
ARG_UNUSED(argc);
626626
ARG_UNUSED(argv);
@@ -636,7 +636,7 @@ static int shell_cmd_allocs(int argc, char *argv[])
636636
return 0;
637637
}
638638

639-
static int shell_cmd_conn(int argc, char *argv[])
639+
int net_shell_cmd_conn(int argc, char *argv[])
640640
{
641641
int count = 0;
642642

@@ -793,7 +793,7 @@ static void print_dns_info(struct dns_resolve_context *ctx)
793793
}
794794
#endif
795795

796-
static int shell_cmd_dns(int argc, char *argv[])
796+
int net_shell_cmd_dns(int argc, char *argv[])
797797
{
798798
#if defined(CONFIG_DNS_RESOLVER)
799799
#define DNS_TIMEOUT 2000 /* ms */
@@ -881,7 +881,7 @@ static int shell_cmd_dns(int argc, char *argv[])
881881
return 0;
882882
}
883883

884-
static int shell_cmd_iface(int argc, char *argv[])
884+
int net_shell_cmd_iface(int argc, char *argv[])
885885
{
886886
ARG_UNUSED(argc);
887887
ARG_UNUSED(argv);
@@ -972,7 +972,7 @@ static void context_info(struct net_context *context, void *user_data)
972972
#endif /* CONFIG_NET_CONTEXT_NET_PKT_POOL */
973973
}
974974

975-
static int shell_cmd_mem(int argc, char *argv[])
975+
int net_shell_cmd_mem(int argc, char *argv[])
976976
{
977977
struct k_mem_slab *rx, *tx;
978978
struct net_buf_pool *rx_data, *tx_data;
@@ -1059,7 +1059,7 @@ static void nbr_cb(struct net_nbr *nbr, void *user_data)
10591059
}
10601060
#endif
10611061

1062-
static int shell_cmd_nbr(int argc, char *argv[])
1062+
int net_shell_cmd_nbr(int argc, char *argv[])
10631063
{
10641064
#if defined(CONFIG_NET_IPV6)
10651065
int count = 0;
@@ -1233,7 +1233,7 @@ static int _ping_ipv4(char *host)
12331233
#endif /* CONFIG_NET_IPV4 */
12341234
#endif /* CONFIG_NET_IPV6 || CONFIG_NET_IPV4 */
12351235

1236-
static int shell_cmd_ping(int argc, char *argv[])
1236+
int net_shell_cmd_ping(int argc, char *argv[])
12371237
{
12381238
char *host;
12391239
int ret;
@@ -1276,7 +1276,7 @@ static int shell_cmd_ping(int argc, char *argv[])
12761276
return 0;
12771277
}
12781278

1279-
static int shell_cmd_route(int argc, char *argv[])
1279+
int net_shell_cmd_route(int argc, char *argv[])
12801280
{
12811281
ARG_UNUSED(argc);
12821282
ARG_UNUSED(argv);
@@ -1299,7 +1299,7 @@ extern char _main_stack[];
12991299
extern char _interrupt_stack[];
13001300
#endif
13011301

1302-
static int shell_cmd_stacks(int argc, char *argv[])
1302+
int net_shell_cmd_stacks(int argc, char *argv[])
13031303
{
13041304
#if defined(CONFIG_INIT_STACKS)
13051305
unsigned int stack_offset, pcnt, unused;
@@ -1346,7 +1346,7 @@ static int shell_cmd_stacks(int argc, char *argv[])
13461346
return 0;
13471347
}
13481348

1349-
static int shell_cmd_stats(int argc, char *argv[])
1349+
int net_shell_cmd_stats(int argc, char *argv[])
13501350
{
13511351
ARG_UNUSED(argc);
13521352
ARG_UNUSED(argv);
@@ -1528,7 +1528,7 @@ static void tcp_sent_cb(struct net_context *context,
15281528
}
15291529
#endif
15301530

1531-
static int shell_cmd_tcp(int argc, char *argv[])
1531+
int net_shell_cmd_tcp(int argc, char *argv[])
15321532
{
15331533
#if defined(CONFIG_NET_TCP)
15341534
int arg = 1;
@@ -1642,7 +1642,7 @@ static int shell_cmd_tcp(int argc, char *argv[])
16421642
return 0;
16431643
}
16441644

1645-
static int shell_cmd_help(int argc, char *argv[])
1645+
int net_shell_cmd_help(int argc, char *argv[])
16461646
{
16471647
ARG_UNUSED(argc);
16481648
ARG_UNUSED(argv);
@@ -1670,18 +1670,18 @@ static int shell_cmd_help(int argc, char *argv[])
16701670

16711671
static struct shell_cmd net_commands[] = {
16721672
/* Keep the commands in alphabetical order */
1673-
{ "allocs", shell_cmd_allocs, NULL },
1674-
{ "conn", shell_cmd_conn, NULL },
1675-
{ "dns", shell_cmd_dns, NULL },
1676-
{ "help", shell_cmd_help, NULL },
1677-
{ "iface", shell_cmd_iface, NULL },
1678-
{ "mem", shell_cmd_mem, NULL },
1679-
{ "nbr", shell_cmd_nbr, NULL },
1680-
{ "ping", shell_cmd_ping, NULL },
1681-
{ "route", shell_cmd_route, NULL },
1682-
{ "stacks", shell_cmd_stacks, NULL },
1683-
{ "stats", shell_cmd_stats, NULL },
1684-
{ "tcp", shell_cmd_tcp, NULL },
1673+
{ "allocs", net_shell_cmd_allocs, NULL },
1674+
{ "conn", net_shell_cmd_conn, NULL },
1675+
{ "dns", net_shell_cmd_dns, NULL },
1676+
{ "help", net_shell_cmd_help, NULL },
1677+
{ "iface", net_shell_cmd_iface, NULL },
1678+
{ "mem", net_shell_cmd_mem, NULL },
1679+
{ "nbr", net_shell_cmd_nbr, NULL },
1680+
{ "ping", net_shell_cmd_ping, NULL },
1681+
{ "route", net_shell_cmd_route, NULL },
1682+
{ "stacks", net_shell_cmd_stacks, NULL },
1683+
{ "stats", net_shell_cmd_stats, NULL },
1684+
{ "tcp", net_shell_cmd_tcp, NULL },
16851685
{ NULL, NULL, NULL }
16861686
};
16871687

subsys/net/ip/net_shell.h

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,17 @@ void net_shell_init(void);
1919
#define net_shell_init(...)
2020
#endif /* CONFIG_NET_SHELL */
2121

22+
int net_shell_cmd_allocs(int argc, char *argv[]);
23+
int net_shell_cmd_conn(int argc, char *argv[]);
24+
int net_shell_cmd_dns(int argc, char *argv[]);
25+
int net_shell_cmd_iface(int argc, char *argv[]);
26+
int net_shell_cmd_mem(int argc, char *argv[]);
27+
int net_shell_cmd_nbr(int argc, char *argv[]);
28+
int net_shell_cmd_ping(int argc, char *argv[]);
29+
int net_shell_cmd_route(int argc, char *argv[]);
30+
int net_shell_cmd_stacks(int argc, char *argv[]);
31+
int net_shell_cmd_stats(int argc, char *argv[]);
32+
int net_shell_cmd_tcp(int argc, char *argv[]);
33+
int net_shell_cmd_help(int argc, char *argv[]);
34+
2235
#endif /* __NET_SHELL_H */

0 commit comments

Comments
 (0)