drivers: gpio: Nios-II: Fix condition on gpio_nios2_config_oput_port()

iha · Anas Nashif · commit e84d1a4f311c · 2018-02-19T20:49:20.000-05:00
(flags &amp; GPIO_DIR_IN) is always zero because GPIO_DIR_IN is 0, then
we have to use GPIO_DIR_MASK.

Signed-off-by: Vitor Massaru Iha &lt;vitor@massaru.org&gt;
diff --git a/drivers/gpio/gpio_altera_nios2.c b/drivers/gpio/gpio_altera_nios2.c
@@ -30,7 +30,7 @@ struct gpio_nios2_config {
 static int gpio_nios2_config_oput_port(struct device *dev, int access_op,
 				       u32_t pin, int flags)
 {
-	if ((flags & GPIO_DIR_IN) || (flags & GPIO_INT)) {
+	if (((flags & GPIO_DIR_MASK) == GPIO_DIR_IN) || (flags & GPIO_INT)) {
 		return -ENOTSUP;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ struct gpio_nios2_config {`
`30`	`30`	`static int gpio_nios2_config_oput_port(struct device *dev, int access_op,`
`31`	`31`	`u32_t pin, int flags)`
`32`	`32`	`{`
`33`		`- if ((flags & GPIO_DIR_IN) \|\| (flags & GPIO_INT)) {`
	`33`	`+ if (((flags & GPIO_DIR_MASK) == GPIO_DIR_IN) \|\| (flags & GPIO_INT)) {`
`34`	`34`	`return -ENOTSUP;`
`35`	`35`	`}`
`36`	`36`