Skip to content

Commit 3bc67f0

Browse files
committed
tests: net: tcp2: Add more debugging info
It is useful to know which test fails to semaphore timeout so add line number of the failing test to assert print. Signed-off-by: Jukka Rissanen <[email protected]>
1 parent 46106ec commit 3bc67f0

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

tests/net/tcp2/src/main.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,13 @@ static void test_sem_give(void)
149149
k_sem_give(&test_sem);
150150
}
151151

152-
static void test_sem_take(k_timeout_t timeout)
152+
static void test_sem_take(k_timeout_t timeout, int line)
153153
{
154154
sem = true;
155155
k_sem_take(&test_sem, timeout);
156156

157157
if (sem) {
158-
zassert_true(false, "semaphore timed out");
158+
zassert_true(false, "semaphore timed out (line %d)", line);
159159
}
160160
}
161161

@@ -467,22 +467,22 @@ static void test_client_ipv4(void)
467467
/* Peer will release the semaphone after it receives
468468
* proper ACK to SYN | ACK
469469
*/
470-
test_sem_take(K_MSEC(100));
470+
test_sem_take(K_MSEC(100), __LINE__);
471471

472472
ret = net_context_send(ctx, &data, 1, NULL, K_NO_WAIT, NULL);
473473
if (ret < 0) {
474474
zassert_true(false, "Failed to send data to peer");
475475
}
476476

477477
/* Peer will release the semaphone after it sends ACK for data */
478-
test_sem_take(K_MSEC(100));
478+
test_sem_take(K_MSEC(100), __LINE__);
479479

480480
net_tcp_put(ctx);
481481

482482
/* Peer will release the semaphone after it receives
483483
* proper ACK to FIN | ACK
484484
*/
485-
test_sem_take(K_MSEC(100));
485+
test_sem_take(K_MSEC(100), __LINE__);
486486
}
487487

488488
/* Test case scenario IPv6
@@ -522,22 +522,22 @@ static void test_client_ipv6(void)
522522
/* Peer will release the semaphone after it receives
523523
* proper ACK to SYN | ACK
524524
*/
525-
test_sem_take(K_MSEC(100));
525+
test_sem_take(K_MSEC(100), __LINE__);
526526

527527
ret = net_context_send(ctx, &data, 1, NULL, K_NO_WAIT, NULL);
528528
if (ret < 0) {
529529
zassert_true(false, "Failed to send data to peer");
530530
}
531531

532532
/* Peer will release the semaphone after it sends ACK for data */
533-
test_sem_take(K_MSEC(100));
533+
test_sem_take(K_MSEC(100), __LINE__);
534534

535535
net_tcp_put(ctx);
536536

537537
/* Peer will release the semaphone after it receives
538538
* proper ACK to FIN | ACK
539539
*/
540-
test_sem_take(K_MSEC(100));
540+
test_sem_take(K_MSEC(100), __LINE__);
541541
}
542542

543543
static void handle_server_test(sa_family_t af, struct tcphdr *th)
@@ -681,7 +681,7 @@ static void test_server_ipv4(void)
681681
/* test_tcp_accept_cb will release the semaphone after succesfull
682682
* connection.
683683
*/
684-
test_sem_take(K_MSEC(100));
684+
test_sem_take(K_MSEC(100), __LINE__);
685685

686686
/* Trigger the peer to send DATA */
687687
k_delayed_work_submit(&test_server, K_NO_WAIT);
@@ -744,7 +744,7 @@ static void test_server_with_options_ipv4(void)
744744
/* test_tcp_accept_cb will release the semaphone after succesfull
745745
* connection.
746746
*/
747-
test_sem_take(K_MSEC(100));
747+
test_sem_take(K_MSEC(100), __LINE__);
748748

749749
/* Trigger the peer to send DATA */
750750
k_delayed_work_submit(&test_server, K_NO_WAIT);
@@ -807,7 +807,7 @@ static void test_server_ipv6(void)
807807
/* test_tcp_accept_cb will release the semaphone after succesfull
808808
* connection.
809809
*/
810-
test_sem_take(K_MSEC(100));
810+
test_sem_take(K_MSEC(100), __LINE__);
811811

812812
/* Trigger the peer to send DATA */
813813
k_delayed_work_submit(&test_server, K_NO_WAIT);
@@ -863,7 +863,7 @@ static void test_client_syn_resend(void)
863863
}
864864

865865
/* test handler will release the sem once it receives SYN again */
866-
test_sem_take(K_MSEC(500));
866+
test_sem_take(K_MSEC(500), __LINE__);
867867

868868
net_context_put(ctx);
869869
}

0 commit comments

Comments
 (0)