check type immutable

Author: youknowone

Lib/test/test_hashlib.py

@@ -994,8 +994,6 @@ def test_hash_disallow_instantiation(self):
         support.check_disallow_instantiation(self, HASH)
         support.check_disallow_instantiation(self, HASHXOF)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_readonly_types(self):
         for algorithm, constructors in self.constructors_to_test.items():
             # all other types have DISALLOW_INSTANTIATION

stdlib/src/hashlib.rs

@@ -97,7 +97,7 @@ pub mod _hashlib {
         }
     }
 
-    #[pyclass(with(Representable))]
+    #[pyclass(flags(IMMUTABLETYPE), with(Representable))]
     impl PyHasher {
         fn new(name: &str, d: HashWrapper) -> Self {
             Self {
@@ -170,7 +170,7 @@ pub mod _hashlib {
         }
     }
 
-    #[pyclass]
+    #[pyclass(flags(IMMUTABLETYPE))]
     impl PyHasherXof {
         fn new(name: &str, d: HashXofWrapper) -> Self {
             Self {

vm/src/builtins/type.rs

@@ -1455,6 +1455,15 @@ impl SetAttr for PyType {
         value: PySetterValue,
         vm: &VirtualMachine,
     ) -> PyResult<()> {
+        // Check if type is immutable
+        if zelf.slots.flags.has_feature(PyTypeFlags::IMMUTABLETYPE) {
+            return Err(vm.new_type_error(format!(
+                "cannot set '{}' attribute of immutable type '{}'",
+                attr_name.as_str(),
+                zelf.name()
+            )));
+        }
+
         // TODO: pass PyRefExact instead of &str
         let attr_name = vm.ctx.intern_str(attr_name.as_str());
         if let Some(attr) = zelf.get_class_attr(attr_name) {