Skip to content

Commit ad55687

Browse files
authored
Fix behat coverage not generated (#103)
1 parent 0bf3fb2 commit ad55687

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

.github/workflows/reusable-CI-workflow.yml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,15 @@ jobs:
128128
static-checks:
129129
name: Static analysis
130130
runs-on: ubuntu-latest
131+
env:
132+
SC_PHP_VERSION: 8.2 # Latest supported
131133
steps:
132134
- uses: actions/checkout@v4
133135

134-
- name: Setup PHP 8.2
136+
- name: Setup PHP ${{ env.SC_PHP_VERSION }}
135137
uses: shivammathur/setup-php@v2
136138
with:
137-
php-version: 8.2 # Latest supported
139+
php-version: ${{ env.SC_PHP_VERSION }}
138140
tools: composer
139141
coverage: none
140142
env:
@@ -148,7 +150,7 @@ jobs:
148150
path: |
149151
~/.composer
150152
# Clear the cache if composer json (as composer.lock is in the repo) has been updated
151-
key: tests-${{ env.PHP_VERSION }}-${{ hashFiles('composer.json') }}
153+
key: tests-${{ env.SC_PHP_VERSION }}-${{ hashFiles('composer.json') }}
152154

153155
- name: Build
154156
run: make build
@@ -164,7 +166,7 @@ jobs:
164166
name: Nightly - PHP ${{ matrix.php-version }} & Symfony ${{ matrix.symfony-version }}
165167
runs-on: ubuntu-latest
166168
env:
167-
COMPOSER_OPTIONS: '--optimize-autoloader --ignore-platform-req=php+'
169+
COMPOSER_OPTIONS: '--optimize-autoloader --prefer-dist --ignore-platform-req=php+'
168170
continue-on-error: true
169171
needs: [ static-checks, tests ]
170172
strategy:
@@ -180,6 +182,9 @@ jobs:
180182
include:
181183
- symfony-version: '6.3' # Next symfony minor version to manage with latest supported PHP version
182184
php-version: '8.2'
185+
- symfony-version: '4.4' # Fix to avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
186+
php-version: '8.3'
187+
pkg-extra-constraints: 'behat/gherkin:~4.12.0'
183188

184189
steps:
185190
- name: Check out code
@@ -208,14 +213,15 @@ jobs:
208213
- name: Build
209214
run: |
210215
composer config minimum-stability dev \
211-
&& composer require -W ${{ env.COMPOSER_OPTIONS }} \
216+
&& composer require -W ${{ env.COMPOSER_OPTIONS }} --prefer-stable \
212217
symfony/http-foundation:^${{ matrix.symfony-version }} \
213218
symfony/http-kernel:^${{ matrix.symfony-version }} \
214219
symfony/config:^${{ matrix.symfony-version }} \
215220
symfony/dependency-injection:^${{ matrix.symfony-version }} \
216221
symfony/event-dispatcher:^${{ matrix.symfony-version }} \
217222
symfony/routing:^${{ matrix.symfony-version }} \
218-
&& composer update ${{ env.COMPOSER_OPTIONS }} \
223+
${{ matrix.pkg-extra-constraints }} \
224+
&& composer update ${{ env.COMPOSER_OPTIONS }} --prefer-stable \
219225
&& make build
220226
221227
- name: Test

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"yoanm/jsonrpc-server-sdk": "^3.3"
4242
},
4343
"require-dev": {
44-
"behat/behat": "^3.9.0",
44+
"behat/behat": "^3.9.0,<=3.16.1",
4545
"dvdoug/behat-code-coverage": "^5.0",
4646
"matthiasnoback/symfony-config-test": "^4.0",
4747
"matthiasnoback/symfony-dependency-injection-test": "^4.0",

0 commit comments

Comments
 (0)