Skip to content

Commit 35ae63b

Browse files
committed
Polish
1 parent da31f21 commit 35ae63b

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

.github/workflows/reusable-CI-workflow.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,14 @@ jobs:
6262
# Bare minimum => Lowest versions allowed by composer config
6363
- php-version: '${{ inputs.php-min-version }}'
6464
symfony-version: '${{ inputs.symfony-min-version }}'
65-
# Late php migration => Highest symfony version with lowest php version allowed by composer config
66-
- php-version: '${{ inputs.php-min-version }}'
67-
symfony-version: '${{ inputs.symfony-max-version }}'
6865
# Late symfony migration => Lowest symfony version with highest php version allowed by composer config
6966
- php-version: '${{ inputs.php-max-version }}'
7067
symfony-version: '${{ inputs.symfony-min-version }}'
7168
## Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
7269
pkg-extra-constraints: behat/gherkin:~4.12.0
70+
# Late php migration => Highest symfony version with lowest php version allowed by composer config
71+
- php-version: '${{ inputs.php-min-version }}'
72+
symfony-version: '${{ inputs.symfony-max-version }}'
7373
# Special case - Sf 5.4 with highest php version
7474
- php-version: '${{ inputs.php-max-version }}'
7575
symfony-version: '5.4'
@@ -114,8 +114,6 @@ jobs:
114114
- name: Build with PHP ${{ steps.setup-php.outputs.php-version }} & Symfony ${{ matrix.symfony-version }}
115115
run: |
116116
SF_CONSTRAINT="~${{ matrix.symfony-version }}.0"
117-
# Issue with ParamterBag below 4.4.30 => https://github.com/symfony/symfony/commit/3eca446b21607ea1c7a865ece2dd8254c33679cc
118-
${{ matrix.symfony-version < 4.4 && matrix.php-version > 8.0 && 'SF_CONSTRAINT="~4.4.30"' || '' }}
119117
composer require -W \
120118
symfony/http-foundation:${SF_CONSTRAINT} \
121119
symfony/http-kernel:${SF_CONSTRAINT} \

0 commit comments

Comments
 (0)