Skip to content

Commit 8cfb49c

Browse files
committed
Harmonize CI
1 parent d86a489 commit 8cfb49c

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

.github/workflows/coverage-upload.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ permissions:
99
checks: write # For the check run creation !
1010

1111
jobs:
12-
upload:
12+
coverage:
1313
name: Coverage
1414
permissions:
1515
contents: read

.github/workflows/pre-check-CI-updates.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
contents: read
3131
uses: ./.github/workflows/reusable-CI-workflow.yml
3232

33-
upload:
33+
coverage:
3434
name: Coverage
3535
needs: [tests]
3636
permissions:

.github/workflows/reusable-CI-workflow.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,9 @@ jobs:
222222
needs: [ fetch-supported-versions, tests ]
223223
if: ${{ github.event_name == 'push' || ( github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'with-nightly-tests') ) }}
224224
runs-on: ubuntu-latest
225-
continue-on-error: true
226225
permissions:
227226
contents: read
227+
continue-on-error: true
228228
env:
229229
COMPOSER_IGNORE_PLATFORM_REQ: 'php+'
230230
strategy:
@@ -246,7 +246,7 @@ jobs:
246246
symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-next }}
247247
# Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
248248
# Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
249-
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-max == '8.4' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}
249+
pkg-extra-constraints: behat/gherkin:~4.12.0 ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-max == '8.4' ) && 'symfony/framework-bundle:~7.0.0@dev' || '' }}
250250
- job-name: Symfony - With lowest supported PHP version
251251
# Fix - Sf 7.0 require php 8.1 minimum, most of deps require 8.2 !
252252
php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.0' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}

.github/workflows/reusable-coverage-upload-workflow.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ jobs:
3232
outputs:
3333
commit-sha: ${{ steps.fetch-workflow-metadata.outputs.commit-sha }}
3434
run-id: ${{ steps.fetch-workflow-metadata.outputs.run-id }}
35+
branch: ${{ steps.fetch-workflow-metadata.outputs.branch }}
36+
pull-request: ${{ steps.fetch-workflow-metadata.outputs.pull-request }}
3537

3638
codacy-uploader:
3739
name: Codacy
@@ -64,6 +66,6 @@ jobs:
6466
run-id: ${{ needs.fetch-info.outputs.run-id }}
6567
force-git-commit: ${{ needs.fetch-info.outputs.commit-sha }}
6668
force-git-branch: ${{ needs.fetch-info.outputs.branch }}
67-
force-gh-pr: ${{ needs.fetch-info.outputs.pr-number }}
69+
force-gh-pr: ${{ needs.fetch-info.outputs.pull-request }}
6870
force-uploader-build: ${{ needs.fetch-info.outputs.run-id }}
6971
force-uploader-build-url: ${{ needs.fetch-info.outputs.run-url }}

0 commit comments

Comments
 (0)