Improve

Author: yoanm

.github/workflows/dependabot-PRs.yml

@@ -7,11 +7,12 @@ permissions:
 
 jobs:
   dependabot:
+    name: Auto-merge & Labels
+    if: github.event.pull_request.user.login == 'dependabot[bot]' && github.repository == 'yoanm/php-jsonrpc-params-symfony-validator-sdk'
     runs-on: ubuntu-latest
     permissions:
       contents: write
       pull-requests: write
-    if: github.event.pull_request.user.login == 'dependabot[bot]' && github.repository == 'yoanm/php-jsonrpc-params-symfony-validator-sdk'
     steps:
       - name: Dependabot metadata
         id: metadata

.github/workflows/reusable-CI-workflow.yml

@@ -119,6 +119,9 @@ jobs:
 
       - name: Build with PHP ${{ steps.setup-php.outputs.php-version }} & Symfony ${{ matrix.symfony-version }}
         run: |
+          # Rely on "composer update --with" rather than "composer require" !
+          # => it ensures the tested version is actually allowed by constraints
+          # ("composer require" would override those constraints, which may not produce something actually installable by end-user)
           SF_CONSTRAINT="~${{ matrix.symfony-version }}.0"
           composer update --no-install --with-all-dependencies --minimal-changes \
             --with "symfony/validator:${SF_CONSTRAINT}" \
@@ -201,6 +204,9 @@ jobs:
 
       - name: Build with PHP ${{ steps.setup-php.outputs.php-version }} & Symfony ${{ env.SYMFONY_VERSION }}
         run: |
+          # Rely on "composer update --with" rather than "composer require" !
+          # => it ensures the tested version is actually allowed by constraints
+          # ("composer require" would override those constraints, which may not produce something actually installable by end-user)
           SF_CONSTRAINT="~${{ env.SYMFONY_VERSION }}.0"
           composer update --no-install --with-all-dependencies --minimal-changes \
               --with "symfony/validator:${SF_CONSTRAINT}" \
@@ -231,25 +237,23 @@ jobs:
             php-version: ${{ needs.fetch-supported-versions.outputs.php-next }}
             symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-max }}
             # Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
-            pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
+            pkg-extra-constraints: behat/gherkin:~4.12.0
           - job-name: PHP with lowest supported Symfony versions
             php-version: ${{ needs.fetch-supported-versions.outputs.php-next }}
             symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-min }}
             # Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
-            pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
+            pkg-extra-constraints: behat/gherkin:~4.12.0
           - job-name: Symfony with highest supported PHP version
             php-version: ${{ needs.fetch-supported-versions.outputs.php-max }}
             symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-next }}
             # Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
-            # Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
-            pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
+            pkg-extra-constraints: behat/gherkin:~4.12.0
           - job-name: Symfony with lowest supported PHP version
             # Fix - symfony/validator  7.1 require php 8.2 minimum !
             php-version: ${{ ( needs.fetch-supported-versions.outputs.symfony-next == '7.1' && needs.fetch-supported-versions.outputs.php-min == '8.0' ) && '8.2' || needs.fetch-supported-versions.outputs.php-min }}
             symfony-version: ${{ needs.fetch-supported-versions.outputs.symfony-next }}
             # Fix - behat/gherkin => Avoid issue with behat <-> gherkin packages (See https://github.com/Behat/Gherkin/issues/317)
-            # Fix - symfony/framework-bundle - Framework bundle <7.0 require php 8.1 minimum !
-            pkg-extra-constraints: --with 'behat/gherkin:~4.12.0'
+            pkg-extra-constraints: behat/gherkin:~4.12.0
 
     steps:
       - name: Check out code
@@ -280,10 +284,12 @@ jobs:
 
       - name: Build with PHP ${{ steps.setup-php.outputs.php-version }} & Symfony ${{ matrix.symfony-version }}
         run: |
+          # For nightly builds, rely on "composer require" rather than "composer update --with" !
+          # => tested version is likely outside of constraints, in that case "composer update --with" would fail
           SF_CONSTRAINT="~${{ matrix.symfony-version }}.0@dev"
           composer config minimum-stability dev \
-          && composer update --no-install --with-all-dependencies --minimal-changes \
-            --with "symfony/validator:${SF_CONSTRAINT}" \
+          && composer require --no-install --with-all-dependencies --minimal-changes \
+            symfony/validator:${SF_CONSTRAINT} \
             ${{ matrix.pkg-extra-constraints }} \
           && make build