Skip to content

Generate classname from test data #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2015
Merged

Generate classname from test data #100

merged 1 commit into from
Nov 18, 2015

Conversation

@gliptak
Copy link
Contributor

@gliptak gliptak commented Nov 14, 2015

Allows for doctest names (intending to keep backward compatibility)

@gliptak gliptak mentioned this pull request Nov 14, 2015
Closed
@landscape-bot
Copy link

landscape-bot commented Nov 14, 2015

Code Health
Repository health decreased by 0.67% when pulling d0dcf86 on gliptak:classname into 49c957e on xmlrunner:master.

@landscape-bot
Copy link

landscape-bot commented Nov 14, 2015

Code Health
Code quality remained the same when pulling 3bf2258 on gliptak:classname into 49c957e on xmlrunner:master.

@landscape-bot
Copy link

landscape-bot commented Nov 14, 2015

Code Health
Repository health decreased by 0.59% when pulling 49ad387 on gliptak:classname into f0910b7 on xmlrunner:master.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 14, 2015

landscape-bot didn't trigger for a633966. just did

@landscape-bot
Copy link

landscape-bot commented Nov 14, 2015

Code Health
Repository health increased by 0.15% when pulling a633966 on gliptak:classname into f0910b7 on xmlrunner:master.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 15, 2015

@dnozay Did you have a chance to review? Thanks

@dnozay
Copy link
Member

dnozay commented Nov 15, 2015

The needs_testcase label means that this pull request does not have any tests to verify behavior. Could you please add some tests to make sure there are no regressions? Thank you.

@landscape-bot
Copy link

landscape-bot commented Nov 16, 2015

Code Health
Repository health increased by 0.19% when pulling 40b9f1b on gliptak:classname into 592d96a on xmlrunner:master.

@gliptak gliptak mentioned this pull request Nov 16, 2015
Closed
@landscape-bot
Copy link

landscape-bot commented Nov 16, 2015

Code Health
Repository health increased by 0.20% when pulling 3880a5c on gliptak:classname into 592d96a on xmlrunner:master.

@landscape-bot
Copy link

landscape-bot commented Nov 17, 2015

Code Health
Repository health increased by 0.19% when pulling 227ba79 on gliptak:classname into 592d96a on xmlrunner:master.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 17, 2015

@dnozay Would you like to see other changes? Thanks

dnozay added a commit that referenced this pull request Nov 18, 2015
@dnozay
Merge pull request #100 from gliptak/classname
f152d4f 
Generate classname from test data
@dnozay dnozay merged commit f152d4f into xmlrunner:master Nov 18, 2015
@gliptak gliptak deleted the classname branch December 11, 2015 03:45
@gliptak
Copy link
Contributor Author

gliptak commented Jan 16, 2016

@dnozay Have you decided on a date to release 1.13.1 or 1.14.0? Thanks
apache/spark#9710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs_testcase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gliptak @landscape-bot @dnozay