respect junit xsd, empty properties (issue #90)

Author: dnozay

tests/testsuite.py

@@ -305,7 +305,7 @@ def test_junitxml_properties(self):
         suite.properties = dict(key='value')
         self._test_xmlrunner(suite)
 
-    def test_junitxml_xsd_validation(self):
+    def test_junitxml_xsd_validation_order(self):
         suite = unittest.TestSuite()
         suite.addTest(self.DummyTest('test_fail'))
         suite.addTest(self.DummyTest('test_pass'))
@@ -324,6 +324,20 @@ def test_junitxml_xsd_validation(self):
         i_testcase = output.index('<testcase'.encode('utf8'))
         self.assertTrue(i_properties < i_testcase < i_system_out < i_system_err)
 
+    def test_junitxml_xsd_validation_empty_properties(self):
+        suite = unittest.TestSuite()
+        suite.addTest(self.DummyTest('test_fail'))
+        suite.addTest(self.DummyTest('test_pass'))
+        suite.properties = None
+        outdir = BytesIO()
+        runner = xmlrunner.XMLTestRunner(
+            stream=self.stream, output=outdir, verbosity=self.verbosity,
+            **self.runner_kwargs)
+        runner.run(suite)
+        outdir.seek(0)
+        output = outdir.read()
+        self.assertNotIn('<properties>'.encode('utf8'), output)
+
     def test_xmlrunner_elapsed_times(self):
         self.runner_kwargs['elapsed_times'] = False
         suite = unittest.TestSuite()

xmlrunner/result.py

@@ -300,15 +300,14 @@ def _get_info_by_testcase(self):
         return tests_by_testcase
 
     def _report_testsuite_properties(xml_testsuite, xml_document, properties):
-        xml_properties = xml_document.createElement('properties')
-        xml_testsuite.appendChild(xml_properties)
         if properties:
+            xml_properties = xml_document.createElement('properties')
+            xml_testsuite.appendChild(xml_properties)
             for key, value in properties.items():
                 prop = xml_document.createElement('property')
                 prop.setAttribute('name', str(key))
                 prop.setAttribute('value', str(value))
                 xml_properties.appendChild(prop)
-        return xml_properties
 
     _report_testsuite_properties = staticmethod(_report_testsuite_properties)