NFC: Remove .providedLibrary from PackageReference and its package container

Dependency resolution is switched to use `BoundVersion` to carry
provided library information, `.providedLibrary` is fully obsolete.

Author: xedin

Sources/Build/BuildPlan/BuildPlan.swift

@@ -740,7 +740,7 @@ extension ResolvedPackage {
         switch self.underlying.manifest.packageKind {
         case .registry, .remoteSourceControl, .localSourceControl:
             return true
-        case .root, .fileSystem, .providedLibrary:
+        case .root, .fileSystem:
             return false
         }
     }

Sources/PackageGraph/CMakeLists.txt

@@ -20,7 +20,6 @@ add_library(PackageGraph
   PackageModel+Extensions.swift
   PackageRequirement.swift
   PinsStore.swift
-  ProvidedLibraryPackageContainer.swift
   Resolution/PubGrub/Assignment.swift
   Resolution/PubGrub/ContainerProvider.swift
   Resolution/PubGrub/DiagnosticReportBuilder.swift

Sources/PackageGraph/ModulesGraph.swift

@@ -362,8 +362,6 @@ extension PackageGraphError: CustomStringConvertible {
                     description += " (at '\(path)')"
                 case .remoteSourceControl(let url):
                     description += " (from '\(url)')"
-                case .providedLibrary(let url, let path):
-                    description += " (from \(url) at \(path))"
                 case .registry:
                     break
                 }

Sources/PackageGraph/ProvidedLibraryPackageContainer.swift

@@ -98,13 +98,6 @@ final class ContainerProvider {
                 let result = result.tryMap { container -> PubGrubPackageContainer in
                     let pubGrubContainer = PubGrubPackageContainer(underlying: container, pins: self.pins)
 
-                    // This container is not cached because it's intended to be transparent
-                    // and requested only when forming final assignments. Caching it would
-                    // mean that subsequent calls to `solve` would pick it up.
-                    if case .providedLibrary = package.kind {
-                        return pubGrubContainer
-                    }
-
                     // only cache positive results
                     self.containersCache[package] = pubGrubContainer
                     return pubGrubContainer

Sources/PackageGraph/Resolution/PubGrub/ContainerProvider.swift

@@ -895,7 +895,7 @@ extension PackageRequirement {
 extension PackageReference {
     public func matchingPrebuiltLibrary(in availableLibraries: [ProvidedLibrary]) -> ProvidedLibrary? {
         switch self.kind {
-        case .fileSystem, .localSourceControl, .root, .providedLibrary:
+        case .fileSystem, .localSourceControl, .root:
             return nil // can never match a prebuilt library
         case .registry(let identity):
             if let registryIdentity = identity.registry {

Sources/PackageGraph/Resolution/PubGrub/PubGrubDependencyResolver.swift

@@ -83,7 +83,7 @@ enum ManifestJSONParser {
         case .localSourceControl(let _packagePath):
             // we have a more accurate path than the virtual one
             packagePath = _packagePath
-        case .root(let _packagePath), .fileSystem(let _packagePath), .providedLibrary(_, let _packagePath):
+        case .root(let _packagePath), .fileSystem(let _packagePath):
             // we dont have a more accurate path, and they should be the same
             // asserting (debug only) to make sure refactoring is correct 11/2023
             assert(packagePath == _packagePath, "expecting package path '\(packagePath)' to be the same as '\(_packagePath)'")

Sources/PackageLoading/ManifestJSONParser.swift

@@ -46,8 +46,6 @@ public struct DefaultIdentityResolver: IdentityResolver {
             return try self.resolveIdentity(for: url)
         case .registry(let identity):
             return identity
-        case .providedLibrary(let url, _):
-            return try self.resolveIdentity(for: url)
         }
     }
 

Sources/PackageModel/IdentityResolver.swift

@@ -34,9 +34,6 @@ public struct PackageReference {
         /// A package from  a registry.
         case registry(PackageIdentity)
 
-        /// A prebuilt library provided by a toolchain for a package identified by the given "origin" URL.
-        case providedLibrary(SourceControlURL, AbsolutePath)
-
         // FIXME: we should not need this once we migrate off URLs
         //@available(*, deprecated)
         public var locationString: String {
@@ -52,8 +49,6 @@ public struct PackageReference {
             case .registry(let identity):
                 // FIXME: this is a placeholder
                 return identity.description
-            case .providedLibrary(let url, _):
-                return url.absoluteString
             }
         }
 
@@ -75,8 +70,6 @@ public struct PackageReference {
                 return "remoteSourceControl \(url)"
             case .registry(let identity):
                 return "registry \(identity)"
-            case .providedLibrary(let url, let path):
-                return "provided library for \(url) @ \(path)"
             }
         }
 
@@ -131,8 +124,6 @@ public struct PackageReference {
         case .registry(let identity):
             // FIXME: this is a placeholder
             self.deprecatedName = name ?? identity.description
-        case .providedLibrary(let url, _):
-            self.deprecatedName = name ?? PackageIdentityParser.computeDefaultName(fromURL: url)
         }
     }
 
@@ -160,14 +151,6 @@ public struct PackageReference {
     public static func registry(identity: PackageIdentity) -> PackageReference {
         PackageReference(identity: identity, kind: .registry(identity))
     }
-
-    public static func providedLibrary(
-        identity: PackageIdentity,
-        origin: SourceControlURL,
-        path: AbsolutePath
-    ) -> PackageReference {
-        PackageReference(identity: identity, kind: .providedLibrary(origin, path))
-    }
 }
 
 extension PackageReference: Equatable {
@@ -187,11 +170,6 @@ extension PackageReference: Equatable {
         switch (self.kind, other.kind) {
         case (.remoteSourceControl(let lurl), .remoteSourceControl(let rurl)):
             return lurl.canonicalURL == rurl.canonicalURL
-        case (.remoteSourceControl(let lurl), .providedLibrary(let rurl, _)),
-             (.providedLibrary(let lurl, _), .remoteSourceControl(let rurl)):
-            return lurl.canonicalURL == rurl.canonicalURL
-        case (.providedLibrary(_, let lpath), .providedLibrary(_, let rpath)):
-            return lpath == rpath
         default:
             return true
         }
@@ -246,10 +224,6 @@ extension PackageReference.Kind: Encodable {
         case .registry:
             var unkeyedContainer = container.nestedUnkeyedContainer(forKey: .registry)
             try unkeyedContainer.encode(self.isRoot)
-        case .providedLibrary(let url, let path):
-            var unkeyedContainer = container.nestedUnkeyedContainer(forKey: .providedLibrary)
-            try unkeyedContainer.encode(url)
-            try unkeyedContainer.encode(path)
         }
     }
 }

Sources/PackageModel/PackageReference.swift

@@ -240,8 +240,6 @@ internal struct PluginContextSerializer {
                 return .repository(url: url.absoluteString, displayVersion: String(describing: package.manifest.version), scmRevision: String(describing: package.manifest.revision))
             case .registry(let identity):
                 return .registry(identity: identity.description, displayVersion: String(describing: package.manifest.version))
-            case .providedLibrary(_, _):
-                throw InternalError("provided libraries are not supported in plugin context")
             }
         }