remove text snapshot objects, is-text-changed callbacks and async behaviour of CheckFileResults

Author: Don Syme

CodeFix/ReplaceWithSuggestion.fs

@@ -45,7 +45,7 @@ type internal FSharpReplaceWithSuggestionCodeFixProvider
             let fcsCaretLineNumber = Line.fromZ caretLinePos.Line
             let partialName = QuickParse.GetPartialLongNameEx(caretLine.ToString(), caretLinePos.Character - 1)
 
-            let! declInfo = checkFileResults.GetDeclarationListInfo(Some parseFileResults, fcsCaretLineNumber, caretLine.ToString(), partialName, userOpName=userOpName) |> liftAsync
+            let declInfo = checkFileResults.GetDeclarationListInfo(Some parseFileResults, fcsCaretLineNumber, caretLine.ToString(), partialName)
             let addNames (addToBuffer:string -> unit) = 
                 for item in declInfo.Items do
                     addToBuffer item.Name

Completion/CompletionProvider.fs

@@ -122,8 +122,8 @@ type internal FSharpCompletionProvider
                 |> List.filter (fun assemblySymbol -> 
                      assemblySymbol.FullName.Contains "." && not (PrettyNaming.IsOperatorName assemblySymbol.Symbol.DisplayName))
 
-            let! declarations = checkFileResults.GetDeclarationListInfo(Some(parseResults), fcsCaretLineNumber, caretLine.ToString(), 
-                                                                        partialName, getAllSymbols, userOpName=userOpName) |> liftAsync
+            let declarations = checkFileResults.GetDeclarationListInfo(Some(parseResults), fcsCaretLineNumber, caretLine.ToString(), 
+                                                                       partialName, getAllSymbols)
             let results = List<Completion.CompletionItem>()
 
             declarationItems <-