Project cache size option (dotnet#3330)

* add option to disable in-memory cross-project references

* fix build

* add "Language Service Performance" option page

* (wip) add "Project Check Cache Size" option

* pass Settings.LanguageServicePerformance.ProjectCheckCacheSize to FSharpChecker.Create

* address the code review

* rename property page, validate project check cache size

Author: vasily-kirichenko

Common/Constants.fs

@@ -68,3 +68,7 @@ module internal Guids =
     [<Literal>]
     /// "9A66EB6A-DE52-4169-BC26-36FBD4312FD7"
     let codeFixesOptionPageIdString = "9A66EB6A-DE52-4169-BC26-36FBD4312FD7"
+
+    [<Literal>]
+    /// "8FDA964A-263D-4B4E-9560-29897535217C"
+    let languageServicePerformanceOptionPageIdString = "8FDA964A-263D-4B4E-9560-29897535217C"

FSharp.Editor.resx

@@ -174,6 +174,9 @@
   <data name="6010" xml:space="preserve">
     <value>Code Fixes</value>
   </data>
+  <data name="6011" xml:space="preserve">
+    <value>Performance</value>
+  </data>
   <data name="TheValueIsUnused" xml:space="preserve">
     <value>The value is unused</value>
   </data>

LanguageService/LanguageService.fs

@@ -22,7 +22,6 @@ open Microsoft.CodeAnalysis.Completion
 open Microsoft.CodeAnalysis.Options
 open Microsoft.VisualStudio
 open Microsoft.VisualStudio.Editor
-open Microsoft.VisualStudio.Text
 open Microsoft.VisualStudio.TextManager.Interop
 open Microsoft.VisualStudio.LanguageServices.Implementation.LanguageService
 open Microsoft.VisualStudio.LanguageServices.Implementation.ProjectSystem
@@ -46,7 +45,12 @@ type internal FSharpCheckerProvider
 
     let checker = 
         lazy
-            let checker = FSharpChecker.Create(projectCacheSize = 200, keepAllBackgroundResolutions = false (* , MaxMemory = 2300 *), legacyReferenceResolver=Microsoft.FSharp.Compiler.MSBuildReferenceResolver.Resolver)
+            let checker = 
+                FSharpChecker.Create(
+                    projectCacheSize = Settings.LanguageServicePerformance.ProjectCheckCacheSize, 
+                    keepAllBackgroundResolutions = false,
+                    (* , MaxMemory = 2300 *) 
+                    legacyReferenceResolver=Microsoft.FSharp.Compiler.MSBuildReferenceResolver.Resolver)
 
             // This is one half of the bridge between the F# background builder and the Roslyn analysis engine.
             // When the F# background builder refreshes the background semantic build context for a file,
@@ -126,18 +130,18 @@ type internal ProjectInfoManager
             // compiled and #r will refer to files on disk
             let referencedProjectFileNames = [| |] 
             let site = ProjectSitesAndFiles.CreateProjectSiteForScript(fileName, referencedProjectFileNames, options)
-            return ProjectSitesAndFiles.GetProjectOptionsForProjectSite(tryGetOptionsForReferencedProject,site,fileName,options.ExtraProjectInfo,serviceProvider, true)
+            return ProjectSitesAndFiles.GetProjectOptionsForProjectSite(Settings.LanguageServicePerformance.EnableInMemoryCrossProjectReferences, tryGetOptionsForReferencedProject,site,fileName,options.ExtraProjectInfo,serviceProvider, true)
         else
             let site = ProjectSitesAndFiles.ProjectSiteOfSingleFile(fileName)
-            return ProjectSitesAndFiles.GetProjectOptionsForProjectSite(tryGetOptionsForReferencedProject,site,fileName,extraProjectInfo,serviceProvider, true)
+            return ProjectSitesAndFiles.GetProjectOptionsForProjectSite(Settings.LanguageServicePerformance.EnableInMemoryCrossProjectReferences, tryGetOptionsForReferencedProject,site,fileName,extraProjectInfo,serviceProvider, true)
       }
 
     /// Update the info for a project in the project table
     member this.UpdateProjectInfo(tryGetOrCreateProjectId, projectId: ProjectId, site: IProjectSite, workspace: Workspace, userOpName) =
         this.AddOrUpdateProject(projectId, (fun isRefresh -> 
             let extraProjectInfo = Some(box workspace)
             let tryGetOptionsForReferencedProject f = f |> tryGetOrCreateProjectId |> Option.bind this.TryGetOptionsForProject
-            let referencedProjects, options = ProjectSitesAndFiles.GetProjectOptionsForProjectSite(tryGetOptionsForReferencedProject, site, site.ProjectFileName(), extraProjectInfo, serviceProvider, true)
+            let referencedProjects, options = ProjectSitesAndFiles.GetProjectOptionsForProjectSite(Settings.LanguageServicePerformance.EnableInMemoryCrossProjectReferences, tryGetOptionsForReferencedProject, site, site.ProjectFileName(), extraProjectInfo, serviceProvider, true)
             let referencedProjectIds = referencedProjects |> Array.choose tryGetOrCreateProjectId
             checkerProvider.Checker.InvalidateConfiguration(options, startBackgroundCompileIfAlreadySeen = not isRefresh, userOpName= userOpName + ".UpdateProjectInfo")
             referencedProjectIds, options))
@@ -231,6 +235,7 @@ type
     [<ProvideLanguageEditorOptionPage(typeof<OptionsUI.IntelliSenseOptionPage>, "F#", null, "IntelliSense", "6008")>]
     [<ProvideLanguageEditorOptionPage(typeof<OptionsUI.QuickInfoOptionPage>, "F#", null, "QuickInfo", "6009")>]
     [<ProvideLanguageEditorOptionPage(typeof<OptionsUI.CodeFixesOptionPage>, "F#", null, "Code Fixes", "6010")>]
+    [<ProvideLanguageEditorOptionPage(typeof<OptionsUI.LanguageServicePerformanceOptionPage>, "F#", null, "Performance", "6011")>]
     [<ProvideLanguageService(languageService = typeof<FSharpLanguageService>,
                              strLanguageName = FSharpConstants.FSharpLanguageName,
                              languageResourceID = 100,

Options/EditorOptions.fs

@@ -36,6 +36,11 @@ type CodeFixesOptions =
       AlwaysPlaceOpensAtTopLevel: bool
       UnusedOpens: bool }
 
+[<CLIMutable>]
+type LanguageServicePerformanceOptions = 
+    { EnableInMemoryCrossProjectReferences: bool
+      ProjectCheckCacheSize: int }
+
 [<Export(typeof<ISettings>)>]
 type internal Settings [<ImportingConstructor>](store: SettingsStore) =
     do  // Initialize default settings
@@ -56,11 +61,16 @@ type internal Settings [<ImportingConstructor>](store: SettingsStore) =
               AlwaysPlaceOpensAtTopLevel = false
               UnusedOpens = true }
 
+        store.RegisterDefault
+            { EnableInMemoryCrossProjectReferences = true
+              ProjectCheckCacheSize = 200 }
+
     interface ISettings
 
     static member IntelliSense : IntelliSenseOptions = getSettings()
     static member QuickInfo : QuickInfoOptions = getSettings()
     static member CodeFixes : CodeFixesOptions = getSettings()
+    static member LanguageServicePerformance : LanguageServicePerformanceOptions = getSettings()
 
 module internal OptionsUI =
 
@@ -89,3 +99,9 @@ module internal OptionsUI =
         inherit AbstractOptionPage<CodeFixesOptions>()
         override this.CreateView() =
             upcast CodeFixesOptionControl()            
+
+    [<Guid(Guids.languageServicePerformanceOptionPageIdString)>]
+    type internal LanguageServicePerformanceOptionPage() =
+        inherit AbstractOptionPage<LanguageServicePerformanceOptions>()
+        override this.CreateView() =
+            upcast LanguageServicePerformanceOptionControl()